Qsvm #1418
Qsvm #1418
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| validate_quantum_program_size( | ||
| tb.ref_pydantic("qprog_pauli"), | ||
| expected_width=2, # actual width: 2 | ||
| expected_depth=30, # actual depth: 30 |
There was a problem hiding this comment.
Maybe take some buffer fo the depth here.
There was a problem hiding this comment.
fixed, thanks!
| assert tb.ref("test_score") == 1 | ||
|
|
||
| # test notebook content | ||
| assert tb.ref("test_score_pauli") == 1 |
There was a problem hiding this comment.
Here, and in the line before (which you did not modify), maybe change this to 1.0? or even to <0.98?
In case there will be some fluctuations from time to time?
| @@ -5,54 +5,162 @@ | |||
| "id": "0", | |||
There was a problem hiding this comment.
I prefer : "... is the quantum version of classical Support Vector Machines (SVM)".
Complexity: Maybe write that it is model dependent. Such that it will be clear why it is empty? Another option is to remove this field.
I would add already here in the "abstract" that the potential advantage should be less effective resources in the quantum version compared to the classical one. For a given problem, there might be powerful kernels that "live" in the Hilbert space, and naturally it is easier to apply them on a quantum computer.
Reply via ReviewNB
There was a problem hiding this comment.
- fixed
- yes, your right, removed the field
- added that and a reference to a relevant article
| @@ -5,54 +5,162 @@ | |||
| "id": "0", | |||
There was a problem hiding this comment.
"... component of a matrix, called the kernel matrix".
Nice explanation and intro.
Reply via ReviewNB
| @@ -5,54 +5,162 @@ | |||
| "id": "0", | |||
There was a problem hiding this comment.
Steps 1 and 2 are done for each pair of data points, and Step 3 is done on the resulting kernel matrix.
I did not understand the difference between U_{DE} and U_{\phi}.
Add a subtitle "train", analog to the subtitle "prediction".
Reply via ReviewNB
There was a problem hiding this comment.
- tried to emphasize this
- improved the explanation
- added
| @@ -5,54 +5,162 @@ | |||
| "id": "0", | |||
There was a problem hiding this comment.
It should work as it was - !pip install -qq -U "classiq[qml]" , let me know if otherwise.
Reply via ReviewNB
There was a problem hiding this comment.
not sure, let's discuss
| @@ -5,54 +5,162 @@ | |||
| "id": "0", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
rephrased the sentence
| @@ -5,54 +5,162 @@ | |||
| "id": "0", | |||
There was a problem hiding this comment.
| @@ -5,54 +5,162 @@ | |||
| "id": "0", | |||
There was a problem hiding this comment.
Line #1. from classiq.execution import ExecutionSession
I think this import is not needed anymore. (included under classiq *)
Reply via ReviewNB
| @@ -5,54 +5,162 @@ | |||
| "id": "0", | |||
There was a problem hiding this comment.
PR Description
Some notes
Please make sure that the notebook runs successfully with the latest Classiq version.
Please make sure that you placed the files in an appropriate folder
.ipynband.qmodto be unique across this repository..qmod,.synthesis_options.json,.metadata.jsonIf applicable, please include link to the paper on which the notebook is based, in the notebook itself.
Please use
rebaseon your branch (no merge commits)Please link this PR to the relevant issue
Please make sure to run
pre-commitwhen commiting changesgitin the terminal, make sure to installpre-commitvia runningpip install pre-commitfollowed bypre-commit installpre-commitdocumentationpre-commit.pre-commitmay minorly alter some files. Make sure togit addthe changes done bypre-commit