Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Targets factories to ease {maldipickr} workflow #46

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

add Targets factories to ease {maldipickr} workflow #46

wants to merge 27 commits into from

Commits on May 3, 2024

  1. draft first {target} factories for {maldipickr}

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    86a4a16 View commit details
    Browse the repository at this point in the history

  2. add {targets} and {tarchetypes} as optional dependencies 

    if one uses the {target} factories
    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    55575ee View commit details
    Browse the repository at this point in the history

  3. ignore the guidelines for contributing during pkg build

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2d14543 View commit details
    Browse the repository at this point in the history

  4. forgotten line removal after compilation

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5a97e9f View commit details
    Browse the repository at this point in the history

  5. add inflated changes for import target factory 

    BUT issue: targets and tarchetypes have been moved to Imports instead of
Suggests
    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b5692bd View commit details
    Browse the repository at this point in the history

  6. fix spelling issues

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cb62ce9 View commit details
    Browse the repository at this point in the history

  7. fix having targets and tarchetypes as optional dependencies in Suggests

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4fe03d8 View commit details
    Browse the repository at this point in the history

  8. draft gather_spectra_stats() function

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    28a0489 View commit details
    Browse the repository at this point in the history

  9. add test for structure and fix no visible binding issue

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    e5dc66f View commit details
    Browse the repository at this point in the history

  10. inflate the now tested gather_spectra_stats function 

    this fixes #45
    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0017bd1 View commit details
    Browse the repository at this point in the history

  11. fix typo in target factory example

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    131caf2 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'fix-45-spectra-stats' into targets-factories

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c91f260 View commit details
    Browse the repository at this point in the history

  13. add section for {targets} functions 

    fix typo
    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1257a2a View commit details
    Browse the repository at this point in the history

  14. add TODOs and better explanations of target objects

    @cpauvert
    cpauvert committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7f2d55f View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. add explicit section title for factory and link to docs

    @cpauvert
    cpauvert committed May 6, 2024
    Configuration menu
    Copy the full SHA
    12e5220 View commit details
    Browse the repository at this point in the history

  2. precise TODO for inherited options

    @cpauvert
    cpauvert committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a830afd View commit details
    Browse the repository at this point in the history

  3. describe the targets objects obtained with the factory 

    plus a bit of inflated changes
    @cpauvert
    cpauvert committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f94d897 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into targets-factories

    @cpauvert
    cpauvert committed May 6, 2024
    Configuration menu
    Copy the full SHA
    7f43051 View commit details
    Browse the repository at this point in the history

  5. make the call to factory cleaner using symbol to prefix targets names

    @cpauvert
    cpauvert committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bfb1623 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. add {coop} to Suggests packages

    @cpauvert
    cpauvert committed May 8, 2024
    Configuration menu
    Copy the full SHA
    35aecfe View commit details
    Browse the repository at this point in the history

  2. initiate the target factory for delineation

    @cpauvert
    cpauvert committed May 8, 2024
    Configuration menu
    Copy the full SHA
    23a821f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. extend the factory up to the picking step

    @cpauvert
    cpauvert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    7e4584c View commit details
    Browse the repository at this point in the history

  2. fix typo

    @cpauvert
    cpauvert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    60bd383 View commit details
    Browse the repository at this point in the history

  3. fix issue with unrecognized processed list

    @cpauvert
    cpauvert committed May 9, 2024
    Configuration menu
    Copy the full SHA
    166ee94 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. convert the factory output from vectors to list 

    this fixes a downstream issue with list structure for
`merge_processed_spectra`
    @cpauvert
    cpauvert committed May 13, 2024
    Configuration menu
    Copy the full SHA
    dbfbf3f View commit details
    Browse the repository at this point in the history

  2. draft test for targets factory

    @cpauvert
    cpauvert committed May 13, 2024
    Configuration menu
    Copy the full SHA
    8afef9e View commit details
    Browse the repository at this point in the history

  3. add test for import spectra target factory 

    inspired by examples in ropensci/jagstargets
    @cpauvert
    cpauvert committed May 13, 2024
    Configuration menu
    Copy the full SHA
    875e2a2 View commit details
    Browse the repository at this point in the history