remove listener when logging out #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchung01
suggested changes
Aug 27, 2024
There was a problem hiding this comment.
Just one small issue to fix, but otherwise looks good. Considering RLMixins has a similar mixin to fix this, would be good to fix the bug natively.
| @@ -724,6 +724,12 @@ public void onEntityCreated(EntityJoinWorldEvent event) { | |||
| PlayerContainerListener.refreshListener((EntityPlayer) event.getEntity()); | |||
| } | |||
|
|
|||
| @SubscribeEvent | |||
| public static void onPlayerLoggedOut(PlayerEvent.PlayerLoggedOutEvent event) { | |||
There was a problem hiding this comment.
Event listener cannot be static, we're registering an instance of EventHandler to the event bus.
Rongmario
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes in this PR:
currently it just... stays there. waiting. listening.