Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3228]Enable the openGui data longer than 128 bits #58

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Ecdcaeb
Copy link
Contributor

@Ecdcaeb Ecdcaeb commented Feb 16, 2024

warning! break the network compat with old forge server/client.
MinecraftForge/MinecraftForge#3228

warning! break the network compat with old forge server/client.
MinecraftForge/MinecraftForge#3228
@kappa-maintainer
Copy link
Collaborator

Two problem:

  • You don't need to call net.minecraftforge.common.MinecraftForge.EVENT_BUS.post in Forge code, just import it (doing so in vanilla patches is fine)
  • I am not sure if we should break this before release, need further discussion

@Ecdcaeb
Copy link
Contributor Author

Ecdcaeb commented Feb 17, 2024

You don't need to call net.minecraftforge.common.MinecraftForge.EVENT_BUS.post in Forge code, just import it (doing so in vanilla patches is fine)

This part may have belonged to the patch before.
It is not a part of FMLNetworkHandler.
https://github.com/MinecraftForge/FML/blob/master/src/main/java/net/minecraftforge/fml/common/network/internal/FMLNetworkHandler.java#L92

@Ecdcaeb
Copy link
Contributor Author

Ecdcaeb commented Feb 17, 2024

I am not sure if we should break this before release, need further discussion

We can also handle it separately without break it?

@Ecdcaeb Ecdcaeb changed the title Enable the openGui data longer than 128 bits [3228]Enable the openGui data longer than 128 bits May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants