[5092] CraftingFactoriesRegisterEvent & Allow for actual Resource Locations #70
+46
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MinecraftForge/MinecraftForge#5092
and provide a new event which enable register/unregister factories;
Why I could not use _factories.json to define it? But a event?
Of course you can use
json
, but using events is more dynamic, without reflection, and suitable for mods with missing resources.Why dynamic registration is needed
There is currently no way to selectively register Json, and the conditional syntax designed by Forge for Json cannot be used on it. When I create a
Factory
for a optional dependency, however, I have to mark it as a required-dependency.When will resources be missing?
Coremod,or the broken env.