Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change areItemsEqual to ItemHandlerHelper.canItemStacksStack() #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change areItemsEqual to ItemHandlerHelper.canItemStacksStack() #15

wants to merge 2 commits into from

Conversation

juraj-hrivnak
Copy link
Contributor

Because areItemsEqual does not compare NBT.

@brachy84
Copy link
Member

Thats also wrong. areItemStacksEqual compares the stack size, which you definitly not want in this case.
The correct way would be ItemHandlerHelper.canItemStacksStack().

@juraj-hrivnak juraj-hrivnak changed the title Change areItemsEqual to areItemStacksEqual Change areItemsEqual to ItemHandlerHelper.canItemStacksStack() Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juraj-hrivnak @brachy84