-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore words that were missing in lowfat dataset #117
Conversation
@jonathanrobie: I took a look at this tonight and have a couple of notes:
I don't think that removing I noticed that the version of the transform on 1e8a8df#diff-291da101c14c773a2f87ecb73479d4bacfdd5064cea7cfb6a7773fa2fb43af48L216 and that the latest version of the transform uses 1e8a8df#diff-291da101c14c773a2f87ecb73479d4bacfdd5064cea7cfb6a7773fa2fb43af48R216 main:
this branch:
If this is not as expected (and we want all diff --git a/mappings/lowfat-macula-hebrew.xquery b/mappings/lowfat-macula-hebrew.xquery
index bd0b5545..5066aeed 100644
--- a/mappings/lowfat-macula-hebrew.xquery
+++ b/mappings/lowfat-macula-hebrew.xquery
@@ -212,8 +212,11 @@ declare function local:attributes($node)
$node/parent::Node/@GreekStrong ! attribute greekstrong {.},
$node/parent::Node/@StrongNumberX ! attribute strongnumberx {.},
$node/parent::Node/@Unicode ! attribute unicode {.},
-
- $node/@Cat ! attribute class {lower-case(.)},
+
+ if ($node/@Cat) then
+ attribute class {lower-case($node/@Cat)}
+ else
+ attribute class {lower-case($node/parent::Node/@Cat)},
$node/@Rule ! attribute rule {.},
$node/@Unicode ! attribute unicode {.}, (This is just my shot at it; feel free to solve it another way!) |
Yes, |
Only exception I could find was `@unicode` for the subsumed definite articles (e.g. o010010050031ה)
Additional tweaks to restore words lowfat branch
Simplified Lowfat query for Hebrew. Fixes these errors:
Analysis is different than previously. Over time, we should consider when to restore rules-based logic.