Restore words that were missing in lowfat dataset

[jonathanrobie]

Simplified Lowfat query for Hebrew. Fixes these errors:

• Lowfat now contains all Hebrew words, some were missing.
• Lowfat words are now in the same order as in Nodes.
• @Head attribute is present when @Head=true

Analysis is different than previously. Over time, we should consider when to restore rules-based logic.

[jacobwegner]

@jonathanrobie: I took a look at this tonight and have a couple of notes:

• I removed the xfail decorator, so now the test that counts the number of nodes passes again 🎉
• There failures now that @class has been removed from some w elements.

I don't think that removing @class as intentional, but if it was, let me know, and we can adjust the test suite to match.

I noticed that the version of the transform on main had used $node/ancestor::Node[1]/@Cat ! attribute class {.}:

1e8a8df#diff-291da101c14c773a2f87ecb73479d4bacfdd5064cea7cfb6a7773fa2fb43af48L216

and that the latest version of the transform uses $node/@Cat ! attribute class {lower-case(.)}

1e8a8df#diff-291da101c14c773a2f87ecb73479d4bacfdd5064cea7cfb6a7773fa2fb43af48R216

main:

macula-hebrew/WLC/lowfat/08-Rut-001-lowfat.xml

Line 20 in b266405

class="cj"

this branch:

macula-hebrew/WLC/lowfat/08-Rut-001-lowfat.xml

Line 18 in 8f2abfa

strongnumberx="2050b"

If this is not as expected (and we want all w elements to have @class attrs), I think the patch below would fix it:

diff --git a/mappings/lowfat-macula-hebrew.xquery b/mappings/lowfat-macula-hebrew.xquery
index bd0b5545..5066aeed 100644
--- a/mappings/lowfat-macula-hebrew.xquery
+++ b/mappings/lowfat-macula-hebrew.xquery
@@ -212,8 +212,11 @@ declare function local:attributes($node)
 	$node/parent::Node/@GreekStrong ! attribute greekstrong {.},
 	$node/parent::Node/@StrongNumberX ! attribute strongnumberx {.},
 	$node/parent::Node/@Unicode ! attribute unicode {.},
-		
-	$node/@Cat ! attribute class {lower-case(.)},
+
+	if ($node/@Cat) then
+		attribute class {lower-case($node/@Cat)}
+	else
+		attribute class {lower-case($node/parent::Node/@Cat)},
 			
 	$node/@Rule ! attribute rule {.},
 	$node/@Unicode ! attribute unicode {.},

(This is just my shot at it; feel free to solve it another way!)

[jonathanrobie]

Yes, @class needs to be there, and your code looks right.