Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include updated Macula Hebrew <=> MARBLE mapping data #118

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Include updated Macula Hebrew <=> MARBLE mapping data #118

merged 1 commit into from
Apr 11, 2024

Conversation

RickBrannan
Copy link
Contributor

No description provided.

@jacobwegner
Copy link
Collaborator

@RickBrannan Thanks so much for doing this!

I'll let @jonathanrobie weigh in, but I'm wondering if we want to keep morpheme-mappings.xml as-is or if we should remove the @marble attributes from it (but maintain the @n and @morphId attributes) as part of merging this PR.

I would prefer if the mappings here are the most up to date, we not publish the older mappings any longer.

jonathanrobie
jonathanrobie reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@jonathanrobie jonathanrobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - go for it

@jacobwegner jacobwegner merged commit e43a849 into main Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanrobie jonathanrobie jonathanrobie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RickBrannan @jacobwegner @jonathanrobie