Publish a WLC TEI edition that includes macula identifiers #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives us a consistent starting place for any additional transforms
* w elements are not at morpheme level * xml:id indicators are not valid Macula IDs
Look at RUT 1:8 (k, q) elems. Nodes include q but omit k. RUT 4:17 has a pe element that is rendered on Tanach.us and on marble.bible, but is treated as an "after" attribute in Nodes
Consult with Tanach.xsd for other allowed elements.
Ends up being some differences, e.g. * RUT 1:2!9 * Numbering in RUT 2:1 * RUT 4:17!16 (nearly like Marble) This approach is really just using Tanach.us XML as a "skeleton" to hang the w elements; whitespace sensitivity coming next if we go to the morpheme level.
jacobwegner
changed the title
jonathanrobie
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
I was able to compare Genesis 1 and Psalm 1 to the equivalent WLC on tanach.us, and they look good. I did a spot check on both paseq and ׃פ in both tanach.us and symphony in Genesis 1 to make sure they show up in the same places.
I can't guarantee no errors, but this is definitely better than the status quo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
tei-transformpipeline that fetches XML from Tanach.us and transforms it into the TEI dataset published atWLC/tei.sources/tanach.us/xml(all processing happens on the pipeline, making it easier to "refresh" the upstream XML as-needed)The XML file for each book can be viewed in a browser and will be rendered with the wlc-tei.css stylesheet:
WLC/tei/08-ruth.xml
samekhandpeelements are rendered with additional whitespace / line breaks, mimicing the display of the HTML on Tanach.us:WLC/tei/09-1samuel.xml
Or view in the Symphony Browser
The XML uses significant whitespace, e.g.
o090010090111ando090010090121are in separate words, but there is no whitespace between them:Rendering of the new XML can be viewed in the Symphony Browser by adding a
tanachTEI=yquerystring parameter, e.g.https://deploy-preview-370--symphony-preview.netlify.app/?workspace=reading&osisRef=1Sam.1.9&tanachTEI=y&selectedLemma=%D7%A8%D6%B8%D7%90%D6%B8%D7%94