-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
other: group together config file options and refactor #1396
base: main
Are you sure you want to change the base?
Conversation
fb27962
to
557cbed
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1396 +/- ##
==========================================
- Coverage 55.96% 53.52% -2.45%
==========================================
Files 102 109 +7
Lines 18381 17966 -415
==========================================
- Hits 10287 9616 -671
- Misses 8094 8350 +256
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
00d6a5e
to
10502e1
Compare
1ad7e8e
to
36be1a0
Compare
c7aa9ed
to
e81af48
Compare
a2bcab3
to
68e61da
Compare
TODO: Update built-in configs! TODO: Update docs; add section for config file
68e61da
to
4453eaa
Compare
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
Groups together similar config file options. This is a breaking change, and breaks all current config files!
I also took this time to completely redo how configs and args are handled, which cleans up a lot of code and reduces a bunch of duplicate definitions and sketchy code.
TODO before merging:
Furthermore, in the future. Probably worth keeping + publishing the existing one as "v1" or something as follow-up to other: add json schema #1394, and the new one as nightly (and v2 on deploy).DoneOn that note, also gotta figure out how we're doing versioning, then!DoneIssue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)