Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort out some error handling #1475

Closed
wants to merge 1 commit into from
Closed

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jun 1, 2024

Codecov Report

Attention: Patch coverage is 56.18557% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 42.88%. Comparing base (ee2e1fe) to head (78e96ba).

Files Patch % Lines
src/app/query.rs 0.00% 18 Missing ⚠️
src/utils/error.rs 14.28% 18 Missing ⚠️
src/utils/error/collection.rs 0.00% 12 Missing ⚠️
src/options.rs 84.72% 11 Missing ⚠️
src/data_collection/processes/linux.rs 0.00% 7 Missing ⚠️
src/utils/error/config.rs 53.84% 6 Missing ⚠️
src/app.rs 0.00% 2 Missing ⚠️
src/app/process_killer.rs 0.00% 2 Missing ⚠️
src/data_collection/processes/unix/user_table.rs 0.00% 2 Missing ⚠️
src/data_collection/temperature/linux.rs 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1475      +/-   ##
==========================================
+ Coverage   40.94%   42.88%   +1.94%     
==========================================
  Files          99       88      -11     
  Lines       17462    16638     -824     
==========================================
- Hits         7149     7135      -14     
+ Misses      10313     9503     -810     
Flag Coverage Δ
macos-12 ?
ubuntu-latest 42.88% <56.18%> (-0.02%) ⬇️
windows-2019 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang deleted the unify_quote_err branch July 13, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant