Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: show hostname in title #999

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Commits on Jan 11, 2023

  1. Added dynamic battery widget

    For bottom to know that there are no batteries on the system,
    I added the battery::Manager to the options.rs file because
    here is the first moment bottom verifies battery configuration
    by reading the config file, which may or may not contain the
    battery field, but for a better UX, it doesn't matter what bottom
    finds in the config file now, if it doesn't retrieve battery data,
    it just ignores the battery widget all together.
    If needed, it can be adjusted so that if the config file contains
    the battery field, it will still show the widget.
    RaresCon authored and RaresCon committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    3ab8e26 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. CFG guarding for BATTERY module

    I guarded the options.rs in two places for battery module that can be missing in the feature list.
    NitrogenDev committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    41e1807 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Merge pull request #1 from RaresCon/dynamic_battery_widget

    Dynamic battery widget
    RaresCon committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    519d35e View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Configuration menu
    Copy the full SHA
    0b8ff0e View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from RaresCon/revert-1-dynamic_battery_widget

    Revert "Dynamic battery widget"
    RaresCon committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    71d0452 View commit details
    Browse the repository at this point in the history
  3. Added custom terminal title

    I added a new option in terminal and in the config
    file to be able to change the terminal title with
    any custom one. The user can now add `--title` and
    the custom title after it or add the `title_to_hostname`
    field in the config file to set the terminal's name
    to hostname. If there is no option found, then
    the name of the terminal will be set to "Bottom".
    RaresCon committed Jan 21, 2023
    Configuration menu
    Copy the full SHA
    3c8c87b View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Configuration menu
    Copy the full SHA
    948ecb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bf21a16 View commit details
    Browse the repository at this point in the history
  3. Reworked the feature, now if nothing is used to set

    the name of the terminal, it will be set as before
    to its path.
    
    This behaviour will happen when an error happens
    inside the `get_use_terminal_name` function as well.
    RaresCon committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    4d6c136 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    8ced3d1 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Changed the feature according to the suggestions

    I removed the custom title option for terminal and made it use
    the hostname when `--title` is used. The title always contains `btm` now.
    If `--title` or `title_has_hostname = true` (in config file) is not present,
    then the terminal has the previous behaviour.
    RaresCon committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    02d29b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c3811b View commit details
    Browse the repository at this point in the history