Skip to content

introduce sync calls for systems not doing fsync #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasvogel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

introduce sync calls for systems not doing fsync #704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions clickhouse/benchmark.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,22 @@ seq 0 99 | xargs -P100 -I{} bash -c 'wget --continue --progress=dot:giga https:/
sudo mv hits_*.parquet /var/lib/clickhouse/user_files/
sudo chown clickhouse:clickhouse /var/lib/clickhouse/user_files/hits_*.parquet

echo -n "Load time: "
clickhouse-client --time --query "INSERT INTO hits SELECT * FROM file('hits_*.parquet')" --max-insert-threads $(( $(nproc) / 4 ))
# Do a sync before loading the data to make sure we don't penalize the system for having to sync more than it actually wrote
sync

# Measure load time including sync to disk
start=$(date +%s.%N)

clickhouse-client \
--query "INSERT INTO hits SELECT * FROM file('hits_*.parquet')" \
--max-insert-threads $(( $(nproc) / 4 ))
sync

end=$(date +%s.%N)
elapsed=$(echo "$end - $start" | bc)

echo "Load time: $elapsed s"


# Run the queries

Expand Down
92 changes: 46 additions & 46 deletions clickhouse/results/c6a.metal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,53 +5,53 @@
"cluster_size": 1,
"proprietary": "no",
"tuned": "no",
"tags": ["C++","column-oriented","ClickHouse derivative", "lukewarm-cold-run"],
"load_time": 7,
"data_size": 15256709483,
"tags": ["C++","column-oriented","ClickHouse derivative","lukewarm-cold-run"],
"load_time": 157,
"data_size": 15274216477,
"result": [
[0.005, 0.002, 0.002],
[0.085, 0.011, 0.012],
[0.037, 0.014, 0.014],
[0.114, 0.015, 0.015],
[0.308, 0.181, 0.176],
[0.836, 0.175, 0.17],
[0.015, 0.011, 0.011],
[0.017, 0.015, 0.015],
[0.411, 0.301, 0.307],
[0.731, 0.325, 0.324],
[0.203, 0.107, 0.107],
[0.172, 0.095, 0.096],
[0.947, 0.152, 0.142],
[1.667, 0.202, 0.205],
[0.868, 0.152, 0.158],
[0.165, 0.088, 0.078],
[1.988, 0.324, 0.325],
[1.327, 0.251, 0.228],
[3.242, 0.584, 0.575],
[0.066, 0.003, 0.003],
[9.462, 0.065, 0.072],
[10.948, 0.052, 0.048],
[14.053, 0.138, 0.14],
[7.194, 0.162, 0.161],
[1.982, 0.043, 0.043],
[0.987, 0.039, 0.037],
[2.511, 0.045, 0.04],
[0.537, 0.034, 0.035],
[8.458, 0.789, 0.828],
[0.055, 0.034, 0.034],
[0.216, 0.098, 0.091],
[3.671, 0.123, 0.134],
[3.742, 0.955, 0.825],
[9.56, 0.689, 0.672],
[9.598, 0.686, 0.712],
[0.122, 0.065, 0.079],
[0.09, 0.063, 0.06],
[0.048, 0.038, 0.035],
[0.057, 0.027, 0.026],
[0.173, 0.137, 0.134],
[0.038, 0.022, 0.023],
[0.032, 0.016, 0.017],
[0.025, 0.015, 0.015]
[0.004, 0.002, 0.002],
[0.024, 0.011, 0.010],
[0.050, 0.013, 0.013],
[0.112, 0.014, 0.013],
[0.337, 0.185, 0.174],
[0.774, 0.170, 0.175],
[0.015, 0.011, 0.010],
[0.020, 0.014, 0.014],
[0.417, 0.311, 0.303],
[0.630, 0.310, 0.323],
[0.192, 0.108, 0.108],
[0.193, 0.101, 0.097],
[0.858, 0.168, 0.151],
[1.640, 0.216, 0.228],
[0.798, 0.155, 0.169],
[0.172, 0.092, 0.087],
[1.873, 0.338, 0.323],
[1.340, 0.237, 0.248],
[3.119, 0.589, 0.572],
[0.079, 0.003, 0.003],
[9.331, 0.071, 0.074],
[10.847, 0.050, 0.049],
[13.813, 0.134, 0.142],
[7.023, 0.172, 0.167],
[1.883, 0.044, 0.042],
[0.994, 0.036, 0.037],
[2.498, 0.041, 0.044],
[0.531, 0.035, 0.034],
[8.569, 0.942, 0.955],
[0.068, 0.037, 0.036],
[0.231, 0.081, 0.085],
[3.631, 0.123, 0.115],
[3.646, 0.896, 0.783],
[9.465, 0.672, 0.687],
[9.459, 0.667, 0.681],
[0.111, 0.057, 0.060],
[0.085, 0.032, 0.032],
[0.043, 0.026, 0.021],
[0.050, 0.018, 0.017],
[0.160, 0.066, 0.066],
[0.036, 0.015, 0.020],
[0.029, 0.013, 0.012],
[0.027, 0.011, 0.011]
]
}

90 changes: 45 additions & 45 deletions clickhouse/results/c7a.metal-48xl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,52 +6,52 @@
"proprietary": "no",
"tuned": "no",
"tags": ["C++","column-oriented","ClickHouse derivative", "lukewarm-cold-run"],
"load_time": 5,
"data_size": 15252391300,
"load_time": 166,
"data_size": 15271945706,
"result": [
[0.002, 0.002, 0.002],
[0.137, 0.012, 0.011],
[0.083, 0.013, 0.012],
[0.157, 0.018, 0.012],
[0.878, 0.345, 0.33],
[1.113, 0.357, 0.345],
[0.017, 0.011, 0.011],
[0.021, 0.017, 0.018],
[0.764, 0.289, 0.299],
[0.871, 0.31, 0.3],
[0.389, 0.119, 0.116],
[0.69, 0.096, 0.094],
[1.301, 0.105, 0.09],
[2.079, 0.135, 0.128],
[1.417, 0.083, 0.084],
[0.587, 0.056, 0.058],
[2.186, 0.148, 0.145],
[2.011, 0.118, 0.112],
[3.606, 0.27, 0.262],
[0.123, 0.003, 0.003],
[10.047, 0.112, 0.051],
[11.375, 0.045, 0.042],
[14.439, 0.1, 0.092],
[7.726, 0.134, 0.129],
[2.696, 0.033, 0.031],
[1.267, 0.027, 0.025],
[2.753, 0.032, 0.033],
[0.784, 0.044, 0.044],
[8.672, 0.496, 0.487],
[0.086, 0.044, 0.044],
[0.454, 0.062, 0.065],
[3.959, 0.083, 0.064],
[4, 0.316, 0.316],
[9.816, 0.332, 0.305],
[9.839, 0.329, 0.321],
[0.094, 0.043, 0.042],
[0.047, 0.028, 0.027],
[0.031, 0.019, 0.02],
[0.038, 0.017, 0.016],
[0.076, 0.046, 0.045],
[0.027, 0.022, 0.015],
[0.025, 0.014, 0.012],
[0.021, 0.012, 0.012]
[0.003, 0.002, 0.002],
[0.029, 0.012, 0.012],
[0.049, 0.013, 0.012],
[0.124, 0.013, 0.013],
[0.804, 0.356, 0.324],
[1.244, 0.387, 0.379],
[0.014, 0.012, 0.012],
[0.021, 0.020, 0.017],
[0.590, 0.292, 0.291],
[1.141, 0.298, 0.235],
[0.439, 0.138, 0.110],
[0.694, 0.102, 0.099],
[1.347, 0.096, 0.092],
[2.126, 0.150, 0.132],
[1.359, 0.101, 0.102],
[0.293, 0.069, 0.066],
[1.910, 0.167, 0.160],
[1.545, 0.131, 0.129],
[3.236, 0.288, 0.273],
[0.067, 0.004, 0.003],
[9.292, 0.057, 0.068],
[10.922, 0.044, 0.050],
[13.388, 0.115, 0.095],
[6.342, 0.134, 0.137],
[1.914, 0.033, 0.038],
[1.031, 0.027, 0.030],
[2.540, 0.034, 0.039],
[0.563, 0.034, 0.032],
[8.433, 0.580, 0.599],
[0.071, 0.050, 0.050],
[0.201, 0.067, 0.085],
[3.656, 0.082, 0.094],
[3.592, 0.314, 0.320],
[9.383, 0.360, 0.334],
[9.379, 0.359, 0.329],
[0.086, 0.050, 0.056],
[0.087, 0.057, 0.063],
[0.039, 0.029, 0.031],
[0.052, 0.024, 0.024],
[0.194, 0.131, 0.157],
[0.039, 0.024, 0.022],
[0.029, 0.020, 0.018],
[0.023, 0.019, 0.015]
]
}

88 changes: 44 additions & 44 deletions clickhouse/results/c8g.metal-48xl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,52 +6,52 @@
"proprietary": "no",
"tuned": "no",
"tags": ["C++","column-oriented","ClickHouse derivative", "lukewarm-cold-run"],
"load_time": 5,
"data_size": 15247502708,
"load_time": 152,
"data_size": 15267835566,
"result": [
[0.002, 0.002, 0.001],
[0.101, 0.012, 0.011],
[0.042, 0.013, 0.012],
[0.123, 0.012, 0.012],
[0.552, 0.244, 0.278],
[0.939, 0.261, 0.263],
[0.014, 0.01, 0.01],
[0.022, 0.018, 0.018],
[0.621, 0.2, 0.199],
[0.598, 0.206, 0.211],
[0.222, 0.084, 0.081],
[0.564, 0.071, 0.072],
[1.218, 0.076, 0.076],
[1.957, 0.1, 0.1],
[1.262, 0.071, 0.072],
[0.505, 0.044, 0.046],
[2.087, 0.144, 0.141],
[1.856, 0.117, 0.113],
[3.505, 0.239, 0.236],
[0.094, 0.002, 0.002],
[9.814, 0.066, 0.065],
[11.156, 0.034, 0.033],
[14.294, 0.091, 0.094],
[7.562, 0.161, 0.161],
[2.288, 0.032, 0.031],
[1.195, 0.027, 0.027],
[2.673, 0.032, 0.032],
[0.702, 0.029, 0.029],
[8.523, 0.449, 0.448],
[0.093, 0.063, 0.063],
[0.219, 0.046, 0.048],
[3.832, 0.06, 0.061],
[3.799, 0.262, 0.262],
[9.579, 0.287, 0.28],
[9.501, 0.302, 0.287],
[0.14, 0.034, 0.035],
[0.078, 0.051, 0.049],
[0.048, 0.03, 0.029],
[0.054, 0.024, 0.023],
[0.123, 0.086, 0.091],
[0.042, 0.017, 0.019],
[0.029, 0.015, 0.015],
[0.025, 0.012, 0.013]
[0.152, 0.012, 0.013],
[0.226, 0.013, 0.013],
[0.376, 0.013, 0.012],
[0.619, 0.337, 0.323],
[0.961, 0.325, 0.364],
[0.021, 0.011, 0.011],
[0.032, 0.020, 0.021],
[0.582, 0.211, 0.207],
[0.885, 0.217, 0.223],
[0.419, 0.087, 0.083],
[0.671, 0.066, 0.081],
[1.303, 0.086, 0.085],
[2.090, 0.112, 0.111],
[1.370, 0.081, 0.079],
[0.601, 0.047, 0.047],
[2.230, 0.155, 0.152],
[1.972, 0.123, 0.123],
[3.637, 0.258, 0.257],
[0.134, 0.003, 0.003],
[9.972, 0.070, 0.065],
[11.461, 0.038, 0.036],
[13.896, 0.100, 0.101],
[7.397, 0.164, 0.163],
[2.289, 0.034, 0.033],
[1.277, 0.030, 0.030],
[2.759, 0.035, 0.033],
[0.781, 0.032, 0.033],
[8.670, 0.443, 0.439],
[0.118, 0.067, 0.067],
[0.475, 0.086, 0.053],
[3.741, 0.070, 0.067],
[3.895, 0.288, 0.268],
[9.840, 0.298, 0.293],
[9.811, 0.294, 0.301],
[0.155, 0.038, 0.038],
[0.118, 0.057, 0.058],
[0.053, 0.040, 0.035],
[0.075, 0.029, 0.028],
[0.202, 0.107, 0.114],
[0.055, 0.020, 0.022],
[0.040, 0.017, 0.016],
[0.036, 0.016, 0.015]
]
}

17 changes: 15 additions & 2 deletions ursa/benchmark.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,21 @@ seq 0 99 | xargs -P100 -I{} bash -c 'wget --continue --progress=dot:giga https:/
sudo mv hits_*.parquet user_files/
sudo chown clickhouse:clickhouse user_files/hits_*.parquet

echo -n "Load time: "
./ursa client --time --query "INSERT INTO hits SELECT * FROM file('hits_*.parquet')" --max-insert-threads $(( $(nproc) / 4 ))
# Do a sync before loading the data to make sure we don't penalize the system for having to sync more than it actually wrote
sync

# Measure load time including sync to disk
start=$(date +%s.%N)

./ursa client \
--query "INSERT INTO hits SELECT * FROM file('hits_*.parquet')" \
--max-insert-threads $(( $(nproc) / 4 ))
sync

end=$(date +%s.%N)
elapsed=$(echo "$end - $start" | bc)

echo "Load time: $elapsed s"

# Run the queries

Expand Down
Loading