Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make access open for mocking/subclassing #56

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Make access open for mocking/subclassing #56

merged 6 commits into from
Oct 10, 2023

Conversation

jasonm23
Copy link
Contributor

@jasonm23 jasonm23 commented Oct 6, 2023

No description provided.

@jasonm23
Copy link
Contributor Author

jasonm23 commented Oct 9, 2023

@Econa77 It looks like Danger needs more permissions to post comments.

@jasonm23
Copy link
Contributor Author

jasonm23 commented Oct 9, 2023 

bundler: failed to load command: danger (/Users/runner/work/Sauce/Sauce/vendor/bundle/ruby/3.2.0/bin/danger)

@jasonm23
Copy link
Contributor Author

jasonm23 commented Oct 9, 2023

Possible token issue for Danger

My downstream build is passing, might be a cache issue.

I'm not sure.

@Econa77
Copy link
Member

Econa77 commented Oct 9, 2023

@jasonm23 It seems that the default permission of GITHUB_TOKEN of PullRequest from the fork repository is read only.
I tried changing the permissions, so could you please try rebasing?

@jasonm23
Copy link
Contributor Author

jasonm23 commented Oct 9, 2023

should be ok now, thanks

@Econa77
Copy link
Member

Econa77 commented Oct 9, 2023

https://github.com/Clipy/Sauce/actions/runs/6459808996/job/17536562328?pr=56#step:1:18

It still looked like read. I'll investigate a little more.

@Econa77
Copy link
Member

Econa77 commented Oct 9, 2023

@jasonm23 We have temporarily disabled Danger because we were unable to run Danger correctly with the current token ( #62 ). Could you please rebase it again?

@jasonm23
Copy link
Contributor Author

Rebased, thank you

Econa77
Econa77 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Econa77 Econa77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Econa77 Econa77 merged commit 4fa210c into Clipy:master Oct 10, 2023
7 checks passed
@jasonm23
Copy link
Contributor Author

Thank you.

@jasonm23
Copy link
Contributor Author

@Econa77 can you schedule a tag / podspec update please.

@Econa77
Copy link
Member

Econa77 commented Mar 30, 2024

@jasonm23 Sorry for the delay. This change has been released in v2.4.1.

@jasonm23
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Econa77 Econa77 Econa77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasonm23 @Econa77