Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game to click menu & multiple battery voltage stats #285

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

fOmey
Copy link

@fOmey fOmey commented Feb 16, 2017

Added game into the click menu.

@fOmey fOmey changed the title Add game to click menu Game to click menu & multiple battery voltage stats Feb 17, 2017
@fOmey fOmey force-pushed the master branch 4 times, most recently from 14227e4 to dca3e94 Compare February 17, 2017 08:16
@USA-RedDragon
Copy link

These look pretty solid man, but I see one issue: on the rx300, the bottom line's battery voltages are touching each other instead of spaced out like top line. It's neat to see another android rom guy taking an interest in all kinds of custom firmware, even for vapes

@fOmey
Copy link
Author

fOmey commented Mar 1, 2017

Thanks mate, appreciate the kind words.

Unfortunately I wasn't able to test the four battery stats as much as I would of liked, my RX2/3 died recently. Once my replacement parts come in the mail ill have to revisit and fix that up.

@USA-RedDragon
Copy link

I fixed it. I'll send you a pull request. It was simple
I'm also working on battery bars like seen on the RX300's stock fw

@fOmey
Copy link
Author

fOmey commented Mar 1, 2017

Awesome dude, looking forward to seeing your progress.

@USA-RedDragon
Copy link

https://github.com/USA-RedDragon/myevic/commit/00087169ecce505c75643d97384410de38a43b63
Wasn't able to send a PR, but you can cherry pick from that

@fOmey
Copy link
Author

fOmey commented Mar 1, 2017

Oh strange, I could of swore I fixed that already.. I must of checked the files out after fixing them. Thanks for that.

@snclab
Copy link

snclab commented Mar 3, 2017

Hi,

you can do this based on firmware 4.13?

Thanks!

@fOmey
Copy link
Author

fOmey commented Mar 7, 2017

I'm sorry ? I don't exactly know what you mean @snclab..

@snclab
Copy link

snclab commented Mar 7, 2017

I mean, this is based to original VTC 3.03 firmware
can update to firmware last 5.14 ?

also, you can remove the power limit?
with some resistance at times you can not go past a certain power

Thanks very mutch!

@fOmey
Copy link
Author

fOmey commented Mar 7, 2017

What exactly does firmware 5.14 have that myevic does not ?

Power limits are put in place so you don't exceed your battery limits.

@snclab
Copy link

snclab commented Mar 7, 2017

it was only a request
however, you can add in the menu the option to disable the Power Limit?
I used this in the past with the original firmware and patches applied with NFirmwareEditor

Thanks

@fOmey
Copy link
Author

fOmey commented Mar 7, 2017

I realize that, I was just wondering the reasoning behind the request that's all.. is there something in particular ?

There is a bypass mode, that will fire your coils at your battery voltage. Give that a try.. take a look at the readme file.

@snclab
Copy link

snclab commented Mar 7, 2017

Power Limit and Bypass mode, are two different things
with Bypass mode can not set the Watt I want

if you can add the removal of the Power Limit would be very nice
if you do not want to do it, I understand.

Thanks anyway

@fOmey
Copy link
Author

fOmey commented Mar 7, 2017

I understand what your saying, but if you push more power than your battery's can handle its unsafe.. therefore I could not agree to do such a thing.

Bypass mode will allow you to push power beyond the power limit theoretically, however again this can be unsafe..

Please keep in mind these power limits are in place for a reason.

@snclab
Copy link

snclab commented Mar 7, 2017

I know the difference, I used firmware Power Limit turned off for about a year and had no problems.

but Bypass is less practical for experienced users, in my opinion

I hope you can do this

@fOmey
Copy link
Author

fOmey commented Mar 7, 2017

Give me a example of a build you would use and the power you would apply to said build.. because I personally cant see any advantages of going beyond the current power limit.

@snclab
Copy link

snclab commented Mar 8, 2017

with some resistance my box limit as 80W but potentially could go further, usually with a resistance of 0.13Ohm go between 90W and 100W 110W but also smoothly, Cuboid does not go beyond 80W due to the Power Limit

@sedataydin89
Copy link

I am using eVic VTwo Mini, how can I fix the battery percentage section under the interface menu.

@Gartral
Copy link

Gartral commented Mar 11, 2017

@sedataydin89 that looks like a separate bug altogether

@USA-RedDragon
Copy link

Yes that's a separate issue altogether. @sedataydin89
And you're posting it in a pull request which makes no sense. I don't even think that's an issue as much as a U.E. or a PEBCAK error. Maybe an ID-10-T error also

@fOmey
Copy link
Author

fOmey commented Mar 12, 2017

@sedataydin89 If you want to display the battery percentage on the home interface you need to enter edit mode (3 fire button press).. scroll down to the third line of the middle section of the home screen and you will be able to set it to display battery percentage... as others have mentioned this a pull request, if your using my binary and have any issues create a issue on my fork.

@escoltajuverf
Copy link

hello can you guys add charging current and charging voltage on charging screen?
also predicted charging completion time would be nice,
awesome work man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants