Skip to content

Fixes a door-related client-prediction bug #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sero583 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes a door-related client-prediction bug #1615

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/cn/nukkit/block/BlockDoor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ public boolean toggle(Player player) {
this.getLevel().getServer().getPluginManager().callEvent(event);

if (event.isCancelled()) {
getLevel().sendBlocks(new Player[] {player}, new Block[] {this.down()}); // fixes a client-prediction bug
Copy link
Member

@SupremeMortal SupremeMortal Sep 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this only affects the upper part of the door, the code should check for that otherwise it's going to update the block below the door when the lower part is pressed.

Copy link
Contributor Author

@sero583 sero583 Sep 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SupremeMortal I know, anyway this fixes it. Updating only the upper half is leading to nothing. Updating both halfs is just unneeded work, as it seems. So just update the lower half.

return false;
}

Expand Down