-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for openrc #498
Conversation
"service1 0:off 1:off 2:on 3:on 4:on 5:on 6:off\n" | ||
"abc 0:off 1:on 2:on 3:on 4:on 5:on 6:off\n" | ||
"xyz 0:off 1:off 2:off 3:off 4:off 5:off 6:off\n" | ||
f"{self.service} 0:off 1:off 2:on 3:on 4:on 5:on 6:off\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests will surely fail
see
https://github.com/gentoo/guru/blob/master/sys-cluster/pcs/files/pcs-0.11-gentoo-support.patch
bbdf643
to
a0a3853
Compare
checking for GNU default python exec_prefix... ${exec_prefix} Package 'systemd', required by 'virtual:world', not found Consider adjusting the PKG_CONFIG_PATH environment variable if you Alternatively, you may set the environment variables systemd_CFLAGS with your patch the systemd check blocks configure |
@custom82 So there is this nice patch https://github.com/gentoo/guru/blob/master/sys-cluster/pcs/files/pcs-0.11-gentoo-support.patch fixing probably all the OpenRC and Gentoo related issues. Why don't you take it a bit further and submit it as a pull request? |
I really trusted a lot in your patch, our patch written by me and Alessandro Barbieri we don't know how functional it is. |
Well, we have virtually no knowledge of and experience with Gentoo. So if you are able to patch pcs to make it work on Gentoo (which according to the patch you are) and you have access to Gentoo machines to test it, then you already have a big advantage. Not only you wrote openrc driver including tests, you also fixed pam config. Your patch is a great start and only needs a bit of polishing. Mainly, make systemd detection optional instead of removing it. Also, it would be great if replacing It would really make it easier for us if you submitted you patch in a pull request. |
Open pull requests consume resources in our CI systems. Since there was no response from the author of this PR for more than 18 months, I am closing this PR. If you decide to implement requested changes and get your code ready to merge, feel free to open a new pull request and we'll be happy to review it. |
resolves #266