Skip to content

detect: follow up on PR #83 dependency review comments#84

Merged
davidahmann merged 2 commits intomainfrom
codex/pr83-comment-followup
Mar 5, 2026
Merged

detect: follow up on PR #83 dependency review comments#84
davidahmann merged 2 commits intomainfrom
codex/pr83-comment-followup

Conversation

@davidahmann
Copy link
Contributor

Problem

PR #83 introduced two review concerns in dependency detection:

  1. ignored directories were filtered after full traversal, still paying walk cost on large trees
  2. project signal fallback used substring matching and could produce noisy false positives

Changes

  • Traverse repository with detector-local walk and skip ignored directories during traversal (SkipDir) before descending.
  • Collect only dependency manifest candidates during walk for deterministic lightweight scanning.
  • Switch project-signal heuristic to token-boundary keyword matching for repo/readme text.
  • Add dependency detector tests covering:
    • unreadable ignored directory handling
    • no false positive on storage/management text
    • positive signal on explicit keyword token

Validation

  • go test ./core/detect/dependency -count=1
  • go test ./core/detect/... -count=1
  • make prepush-full
  • ./.tmp/wrkr scan --path ./scenarios/wrkr/scan-mixed-org/repos --json > .tmp/pre-ship-scan-pr83-followup.json

@davidahmann davidahmann merged commit 2a35190 into main Mar 5, 2026
7 checks passed
@davidahmann davidahmann deleted the codex/pr83-comment-followup branch March 5, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant