Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b3005ed5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| merged.BindingEvidenceKeys = dedupeSorted(append(append([]string(nil), merged.BindingEvidenceKeys...), incoming.BindingEvidenceKeys...)) | ||
| merged.MissingBindings = dedupeSorted(append(append([]string(nil), merged.MissingBindings...), incoming.MissingBindings...)) | ||
| merged.DeploymentStatus = mergeDeploymentStatus(merged.DeploymentStatus, incoming.DeploymentStatus) | ||
| merged.DeploymentArtifacts = dedupeSorted(append(append([]string(nil), merged.DeploymentArtifacts...), incoming.DeploymentArtifacts...)) |
There was a problem hiding this comment.
mergeAgentContext now routes deployment artifacts through dedupeSorted, which lowercases every token before returning it. For repos that use case-sensitive artifact names (for example Deploy.yml), this changes the recorded evidence path and can make the emitted deployment_artifacts/deployment_evidence_keys no longer match real files, reducing auditability of the privilege map output.
Useful? React with 👍 / 👎.
1 participant
Summary
This follow-up PR addresses actionable review comments from merged PR #89.
Original PR: #89
Implemented comment refs:
Changes
agent_prod_write_human_gateevaluations in mixed agent + secret findings.agent_auto_deploy_gatesatisfiable by deriving/accepting deployment gate evidence deterministically (deployment_gatesupport in agent framework detector plus evaluator fallback).Validation
go test ./core/aggregate/privilegebudget ./core/policy/eval ./core/detect/agentframeworkmake lint-fastmake test-fastmake test-contractsmake prepush-full./.tmp/wrkr scan --path . --json./.tmp/wrkr regress init --baseline ./.wrkr/last-scan.json --output ./.tmp/pr89-regress-baseline.json --json./.tmp/wrkr regress run --baseline ./.tmp/pr89-regress-baseline.json --json