Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About page #65

Merged
merged 2 commits into from
Oct 3, 2021
Merged

About page #65

merged 2 commits into from
Oct 3, 2021

Conversation

nandini7637
Copy link
Contributor

Related Issuse or bug

Fixes: #abo

Proposed Changes

  • Info about changes Goes here

Additional Info

  • Anything related Issues

Screenshots

Original Updated
original screenshot **updated screenshot **

Copy link
Member

@AnkushSinghGandhi AnkushSinghGandhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @nandini7637 I'm not sure what you're attempting to improve here, you just built another about page "about1.html" instead of revising "about.html," and I'm not sure what improvements you're proposing here. In my opinion, the "about" page is cleaner than the "about1" page that you created. However, I am closing this PR while simultaneously labeling it as "hacktoberfest-accepted" so that it will be counted towards hactoberfest.

@AnkushSinghGandhi
Copy link
Member

If I missed something, please reopen the PR. Keep your Open Source spirit high!

@nandini7637
Copy link
Contributor Author

nandini7637 commented Oct 3, 2021

@AnkushSinghGandhi yeah I have made another page because @unnati914 di told me to make a seperate page, that's why I didn't touch the existing code!

@nandini7637
Copy link
Contributor Author

@AnkushSinghGandhi regarding the changes, I have added animated cards for plan, vision, mission. Added Caraousal to show event highlights of Codexcrypt
Added a timeline for showing future or past events and shown the changed to @unnati914 di and I believe the page looks much better than previous one!

@AnkushSinghGandhi
Copy link
Member

@AnkushSinghGandhi yeah I have made another page because @unnati914 di told me to make a seperate page, that's why I didn't touch the existing code!

Oh well I am not aware about that

@AnkushSinghGandhi
Copy link
Member

AnkushSinghGandhi commented Oct 3, 2021

@AnkushSinghGandhi regarding the changes, I have added animated cards for plan, vision, mission. Added Caraousal to show event highlights of Codexcrypt Added a timeline for showing future or past events and shown the changed to @unnati914 di and I believe the page looks much better than previous one!

Yeah it depends person to person so I am approving this PR @unnati914 and that timeline looks cool 😃😃

@unnati914 unnati914 merged commit 782262b into CodXCrypt:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants