Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for InterfaceTypeDefinition #530

Closed
wants to merge 14 commits into from

Conversation

simonljus
Copy link
Contributor

Solves issue #474

Add config option withInterfaceType to make validation schema generation of InterfaceTypeDefinition optional.

Log a warning if an unsupported TargetKind is used in a GQL Schema. By default, unknown target types handle everything as Scalar. If the Scalar is unknown, an Exception will be thrown with an error message about the unknown Scalar.

The difference with InterfaceTypeDefinition compared to ObjectTypeDefinition is the lack of __typename (and Query, Mutation and Subscription

Added test cases similar to some of the withObjectType test cases.

@Code-Hex
Copy link
Owner

Code-Hex commented Apr 6, 2024

@simonljus Sorry I have not been able to read your PR for a long time. I will cherry-pick and merge them later on my end.

@Code-Hex
Copy link
Owner

Code-Hex commented Apr 6, 2024

Resolved conflict at #609

@Code-Hex Code-Hex closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants