Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to allow route guard code to work #4

Open
wants to merge 1 commit into
base: L9-start
Choose a base branch
from

Conversation

ghostal
Copy link

@ghostal ghostal commented Dec 20, 2021

Hi @Gregg! First off, thanks a lot for the course. I'm enjoying learning from it, and especially enjoying the outtakes 😄

I came across a problem with the route guard code, whereby Vue would complain that next() wasn't being run, meaning it considered the route guard to be invalid. Eventually I found the helpful comments by and @platoputhur @Bruce9000 in issue #2.

That got me back on track, and I thought I'd open a PR so the code can be easily updated.

All I've done here is run npm update on the end of the L9-start branch and commit the updated package-lock.json.

As far as I can gather, the key change the solves the problem is that the vue-router package moves from 4.0.0-beta.9 to 4.0.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant