EditorManager Always Opens Files #1892
Open
+55
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoolwinter
changed the title
thecoolwinter
changed the title
thecoolwinter
requested review from
0xWDG,
matthijseikelenboom,
FastestMolasses and
activcoding
activcoding
requested changes
Sep 28, 2024
| } | ||
| self.selectedTab = tab | ||
| if tab.file.fileDocument == nil { | ||
| do { // eat this error for ease of API use. |
There was a problem hiding this comment.
Suggested change
| do { // eat this error for ease of API use. | |
| do { // Ignore this error for simpler API usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the editor manager to use a private variable for the selected tab, and a setter method. This method handles opening the underlying code document if necessary and moves the ownership of opening the code file to the editor manager. This was unclear before, which led to documents being opened multiple times (there was a comment in the editor.swift file about this earlier).
This also updates the history to use the
CEWorkspaceFilerather than tabs, to indicate that items in the history are unrelated to their UI representation and are given a new tab instance when opened (if necessary).Also updates the loading indicator to update the UI when it receives an update as well as attempt to do so when it appears. This change ensure that if the code file property is set, it is reflected in the UI.
Related Issues
Checklist
Screenshots
Screen.Recording.2024-09-26.at.12.21.32.PM.mov