Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scroll to range #70

Merged
merged 13 commits into from
Mar 1, 2025
Merged

feat: Scroll to range #70

merged 13 commits into from
Mar 1, 2025

Conversation

tom-ludwig
Copy link
Member

@tom-ludwig tom-ludwig commented Feb 27, 2025 •
edited
Loading

Description

  • Added functionality to scroll to a specified range.
  • Introduced a feature flag for animated scrolling (currently disabled).
  • Renamed highlightedRanges to emphasizedRanges to align with the class name.
  • Changed emphasizedRanges to public(set) to support upcoming search functionality.

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

@tom-ludwig
Add cgPathFallback property to NSBezierPath for macOS versions < …
ea168f4 
…14 to support conversion to `CGPath`
@tom-ludwig
Add convenience initializer to NSColor for creating color from hex …
ecdf562 
…value
@tom-ludwig
Add smoothPath method to NSBezierPath for smooth path creation
dfeb6eb
@tom-ludwig
Add roundedPathForRange method to create a smooth bezier path for a…
0f2d3a1 
… text range
@tom-ludwig
Add EmphasizeAPI class to manage text range emphasis with dynamic hig…
938c9da 
…hlighting
@tom-ludwig
Moved EmphasizeAPI to it's own folder
97ac5e6
@tom-ludwig
fixed scale animation
a8e3738
@tom-ludwig
Merge remote-tracking branch 'refs/remotes/origin/main'
6a7a090
@tom-ludwig
Add scroll to visible range
3917f61 
- Scrolls to the specified range and centers it
@tom-ludwig
Merge branch 'main' into feat/scrollToRange
cb2b96a
@tom-ludwig
Remove double declaration of emphasizeAPI
1d2f62a
austincondiff
austincondiff reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just fix the SwiftLint error in TextView+ScrollToVisible.swift

@thecoolwinter thecoolwinter merged commit b9c8c1f into main Mar 1, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the feat/scrollToRange branch March 1, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austincondiff austincondiff austincondiff approved these changes

@thecoolwinter thecoolwinter thecoolwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Scroll to range
3 participants
@tom-ludwig @austincondiff @thecoolwinter