Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor tweaks #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor tweaks #7

wants to merge 1 commit into from

Conversation

thejsj
Copy link
Member

@thejsj thejsj commented Sep 14, 2016

WIP! IGNORE!

anandkumarpatel
anandkumarpatel requested changes Sep 14, 2016
View reviewed changes
.helpers.d/ansible.sh
if [[ "${repo}" = "api-core" ]]; then
repo_folder="${RUN_ROOT}/api"
fi
if [[ "${repo}" = "api-core" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean worker?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WIP!!!!! RESPECT THE WIP!!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what the wip label is for ....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, didn't see that... but I did add it to the description! haha

.helpers.d/ansible.sh
@@ -26,7 +32,12 @@ function deploy # <env> <app> <tag> [...extra]
fi

echo ansible-playbook -i "${ANSIBLE_ROOT}/${tenv}" --vault-password-file ~/.vaultpass -e git_branch="${tag}" "${deployFile}" -t deploy "${@}"
ansible-playbook -i "${ANSIBLE_ROOT}/${tenv}" --vault-password-file ~/.vaultpass -e git_branch="${tag}" "${deployFile}" -t deploy "${@}"
if [[ $(which noti) == "" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm what is noti

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this not be done external to the script? alias deployi='noti deploy'

@thejsj thejsj added the WIP label Sep 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandkumarpatel anandkumarpatel anandkumarpatel requested changes

Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thejsj @anandkumarpatel