Skip to content

Sheffield | May-2025 | Waleed-Yahay Salih-Taha | Sprint 2 | Book Library #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bluejay600 wants to merge 18 commits into from
Closed

Sheffield | May-2025 | Waleed-Yahay Salih-Taha | Sprint 2 | Book Library #286

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c830178
bugs are fixed now
aidazhukova Mar 28, 2025
c3b7f29
fixed the if condition's syntax of the missing bracket.
Bluejay600 Aug 9, 2025
e99d6aa
added a title to the web page and a languagge element to the html ope…
Bluejay600 Aug 9, 2025
ff68704
Merge branch 'book-library' of https://github.com/Bluejay600/Module-D…
Bluejay600 Aug 9, 2025
3869805
updated html code
Bluejay600 Aug 16, 2025
300dc39
updated css.
Bluejay600 Aug 16, 2025
6b2c9a9
updated the script file.
Bluejay600 Aug 16, 2025
c21b787
updated and validated html file.
Bluejay600 Aug 17, 2025
5fd2034
updated the input values not to be empty spaces.
Bluejay600 Aug 17, 2025
808cd28
updated css file.
Bluejay600 Aug 17, 2025
6473c1f
Cache DOM elements with clear suffixes
Bluejay600 Aug 18, 2025
60240cb
Grouped all setup codes in window.onload
Bluejay600 Aug 18, 2025
196a070
improved function to addbook
Bluejay600 Aug 18, 2025
2e0943e
Fix delete alert order (show confirmation only after deletion succeed…
Bluejay600 Aug 18, 2025
555c393
updated html code.
Bluejay600 Aug 19, 2025
410104f
fixes js code
Bluejay600 Aug 19, 2025
b77a783
Improve maintainability / readability
Bluejay600 Aug 19, 2025
f032d63
Edited input validation to prevent decimal values (e.g., 12.5 pages).…
Bluejay600 Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title>Book library </title>
<meta
charset="utf-8"
name="viewport"
Expand Down
26 changes: 15 additions & 11 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,16 @@ function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
pages.value == null ||
pages.value == "" ||
author.value == null ||
author.value == ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(title.value, author.value, pages.value, check.checked);
myLibrary.push(book);
render();
}
Comment on lines +50 to 60
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the VSCode extension prettier to auto format/indent the code?

}
Expand All @@ -53,8 +55,10 @@ function Book(title, author, pages, check) {
function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
console.log(myLibrary)

//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
for (let n = rowsNumber - 1; n > 0; n--) {
table.deleteRow(n);
}
//insert updated row and cells
Expand All @@ -76,7 +80,7 @@ function render() {
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
if (myLibrary[i].check == true) {
readStatus = "Yes";
} else {
readStatus = "No";
Expand All @@ -90,11 +94,11 @@ function render() {

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
delButton.id = i + 5;
deleteCell.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.innerHTML = "Delete";
delButton.addEventListener("click", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
Expand Down
Loading