-
-
Notifications
You must be signed in to change notification settings - Fork 240
London | 26-ITP-May | Raihan Sharif | Sprint 1 | Destructuring exercises #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RaihanSharif
wants to merge
8
commits into
CodeYourFuture:main
Choose a base branch
from
RaihanSharif:sprint-1-desctructuring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−1
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7abb238
complete exercise 1
RaihanSharif c0ad8e9
hogwarts exercise done
RaihanSharif e0e4020
complete receipt exercise
RaihanSharif 84ebbef
destructuring with default values
RaihanSharif 1bdaae2
remove dead code, show example usage of general purpose function
RaihanSharif 5cd7baf
removed default values
RaihanSharif dcb2eaa
use more destructuring of objects
RaihanSharif f52238d
use descructuring in the paramter of forEach, and make string padding…
RaihanSharif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These solutions work, but don't use destructuring as much as they could. Given this exercises is about destructuring, can you aim for maximum destructring?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added more destructuring, can this be considered maximum descructuring?
I prefer the previous solution in terms of readability. Though I guess if you have a lot of properties it can get tedious.
What do you think?