Maryna Romanova - Sprint-3 #450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearcyf
reviewed
Apr 1, 2025
Sprint-3/alarmclock/alarmclock.js
Outdated
| const timeRemaining = document.querySelector("#timeValue"); | ||
| const stepTime = 100 | ||
| const startButton = document.querySelector("#set"); | ||
| let isAudioPlaed = false; |
There was a problem hiding this comment.
Yes, english not my fist language, sorry for mistakes.
fearcyf
reviewed
Apr 1, 2025
|
|
||
| function setAlarm() { | ||
| let fistRemaider = +timeRemaining.innerHTML * 1000; | ||
|
|
There was a problem hiding this comment.
is fistRemaider a typo? if not just ignore
fearcyf
reviewed
Apr 1, 2025
Sprint-3/slideshow/style.css
Outdated
There was a problem hiding this comment.
Comments in a different language - amend to English for submission purposes
There was a problem hiding this comment.
All comments in other languages have been removed.
|
Add comments to submissions without them to show thought processes. Other points to be clarified have been noted. |
fearcyf
added
Reviewed
|
Dear @fearcyf ,I have corrected everything you have indicated, please check. If everything is good, then approve my Sprint-3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.