Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITP-JAN-25 | LONDON | Maryna Romanova | Module-Data-Groups | Sprint 2 #451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarynaRomashca
Copy link

@MarynaRomashca MarynaRomashca commented Mar 29, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@MarynaRomashca MarynaRomashca changed the title Maryna Romanova - Sprint 2.0 ITP-JAN-25 | LONDON | Maryna Romanova | Module-Data-Groups | Sprint 2 Mar 29, 2025
@MarynaRomashca MarynaRomashca added the Needs Review Participant to add when requesting review label Mar 29, 2025
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

House number is not defined in const address. Also investigate the console.log method. Suppose I want to return the city. How would I amend console.log to make sure it prints this out.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error message says this object is not iterable. Have a look at this page to assist with solution-> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Iteration_protocols

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be properties for "serves" and "ingredients" to complete this code?

// c) What is the target return value when invert is called with {a : 1, b: 2}

// c) What does Object.entries return? Why is it needed in this program?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c) and d) answers to be expanded

@fearcyf
Copy link

fearcyf commented Apr 1, 2025

I have made a few points to be looked at

@fearcyf fearcyf added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 1, 2025
@fearcyf fearcyf self-assigned this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants