Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

West-Midlands ITP-Jan-2025 | Ifeanyi Madubugwu | Module-Data-Group | Sprint -3| Quote-generator #454

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

West-Midlands ITP-Jan-2025 | Ifeanyi Madubugwu | Module-Data-Group | Sprint -3| Quote-generator #454

wants to merge 4 commits into from

Conversation

Elchacode
Copy link

Learners, PR Template

Self checklist

  • [x ] I have committed my files one by one, on purpose, and for a reason
  • [ x] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ x] I have tested my changes
  • [ x] My changes follow the style guide
  • [x ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@Elchacode Elchacode added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Participant to add when requesting review labels Mar 29, 2025
@prabhveer-mujral prabhveer-mujral added Reviewed Volunteer to add when completing a review and removed Needs Review Participant to add when requesting review labels Apr 4, 2025
prabhveer-mujral
prabhveer-mujral reviewed Apr 4, 2025
View reviewed changes
Sprint-3/quote-generator/style.css
#author {
font-style: italic;
margin-top: 18px;
color: #322128;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice design work!

@prabhveer-mujral
Copy link

Overall good work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhveer-mujral prabhveer-mujral prabhveer-mujral left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review 📅 Sprint 3 Assigned during Sprint 3 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchacode @prabhveer-mujral