JAN 2025 ITP/ ELFREDAH KEVIN-ALERECHI/ DATA GROUPS/Sprint 2 #458

Elfredah · 2025-03-30T03:13:29Z

I deleted the other sprint to ensure I submit the sprint 1 separately<!--

-->

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

day-lee · 2025-04-05T19:38:03Z

Hi, @Elfredah. Please make sure to add the label needs review so it shows up on the volunteers' dashboard. You can get a quicker review once you add a label to your PR.

day-lee · 2025-04-05T19:53:16Z

Sprint-1/fix/median.js

+module.exports = calculateMedian;
+
+
+//======> solution to the right codes to solve the issue is below


The code looks good and passes the test.
One thing I want to mention is that when you share the code with others, please provide the final version to avoid any confusion. If you need the code for future reference, you can comment it out and share it, but the best practice would be to remove any unnecessary code before PR.

day-lee · 2025-04-05T19:54:21Z

Sprint-1/fix/median.test.js

+//const calculateMedian = require("./median.js");
+
+//describe("calculateMedian", () => {
+  //test("returns the median for odd length array", () => {
+    //expect(calculateMedian([1, 2, 3])).toEqual(2);
+    //expect(calculateMedian([1, 2, 3, 4, 5])).toEqual(3);
+  //});
+
+  //test("returns the average of middle values for even length array", () => {
+    //expect(calculateMedian([1, 2, 3, 4])).toEqual(2.5);
+    //expect(calculateMedian([1, 2, 3, 4, 5, 6])).toEqual(3.5);
+  //});
+
+  //test("doesn't modify the input", () => {
+    //const list = [1, 2, 3];
+    //calculateMedian(list);
+
+    //expect(list).toEqual([1, 2, 3]);
+  //});
+//});
+
+//=======> solution to the right codes to solve the issue is below


Please delete any unnecessary commented-out lines.

day-lee · 2025-04-05T19:55:54Z

Sprint-1/fix/median.test.js

+// median.js (the file containing calculateMedian)
+function calculateMedian(list) {
+  if (!list || list.length === 0) {
+    return undefined;
+  }
+
+  const sortedList = [...list].sort((a, b) => a - b);
+  const middleIndex = Math.floor(sortedList.length / 2);
+
+  if (sortedList.length % 2 === 0) {
+    return (sortedList[middleIndex - 1] + sortedList[middleIndex]) / 2;
+  } else {
+    return sortedList[middleIndex];
+  }
+}
+
+module.exports = calculateMedian;


The est.js file should only contain the test suite. Since the function is already written in median.js so you can delete those lines.

day-lee · 2025-04-05T19:58:07Z

Sprint-1/implement/dedupe.js

-function dedupe() {}
+//function dedupe() {}
+// dedupe.js
+function dedupe(arr) {


Nicely done! As a bonus challenge, can you think of a solution that uses Set object as well?

day-lee · 2025-04-05T20:02:09Z

Sprint-1/implement/max.test.js

 // When passed to the max function
 // Then it should return the least surprising value given how it behaves for all other inputs
+
+const findMax = require("./max");


Have you run the test with the npm test <file path> command? I tried it on my local machine, and it fails. I noticed that you wrote this line of code twice in the file.

You will need to delete one of those duplicate const findMax = require("./max"); line to make it work.

day-lee · 2025-04-05T20:14:42Z

Sprint-1/implement/max.js


-module.exports = findMax;
+//module.exports = findMax;
+function findMax(elements) {


With current code, test fails under these conditions.

given an empty array, returns -Infinity given an array with non-number values, returns the max and ignores non-numeric values given an array with only non-number values, returns -Infinity

You need a line of code that checks the type of element in an array(elements) and find max from filteredArray. Can you add the line to filter only the numbers?

day-lee · 2025-04-05T20:17:52Z

Sprint-1/implement/max.js

+function findMax(elements) {
+    // Return undefined if the array is empty
+    if (elements.length === 0) {
+      return undefined;


In the test, it specifies that it needs to return -Infinity, not undefined. This needs to be changed. Additionally, you should check the length of filteredArray because if there are only strings in the array, it means the array has no valid numbers and is effectively an empty array.

test("given an empty array, returns -Infinity", () => { expect(findMax([])).toEqual(-Infinity); });

day-lee · 2025-04-05T20:18:40Z

Sprint-1/implement/max.js

+    }
+
+    // Use Math.max to find the largest number in the array
+    return Math.max(...elements);


Good job using Math.max() function with spread operator to spread the elements from an array.

day-lee · 2025-04-05T20:21:59Z

Sprint-1/implement/sum.js

 function sum(elements) {
 }

 module.exports = sum;


This should be deleted to run the test as it's duplicate and cause an error.

day-lee · 2025-04-05T20:42:07Z

Sprint-1/implement/sum.test.js

+  // Test for an array with decimal/float numbers
+  test("given an array with decimal/float numbers, returns the correct total sum", () => {
+    expect(sum([1.5, 2.5, 3.5])).toEqual(7.5); // 1.5 + 2.5 + 3.5 = 7.5
+    expect(sum([1.1, -0.2, 3.2])).toEqual(4.1); // 1.1 + (-0.2) + 3.2 = 4.1


When I run the test, this test fails as sum([1.1, -0.2, 3.2] returns 4.1000000000000005. This is because JavaScript has one numeric type which is float. This can be not precise and has a rounding issue. Can you think of a solution using parseFloat() and toFixed() function? Check if your final code passes all test as well.

day-lee · 2025-04-05T20:47:43Z

Great job on completing Sprint 1! You did well overall. I've commented on a few minor issues. You can run the test using npm test <path/filename.test.js>. If you have any more questions, feel free to ask! :)

I deleted the other sprint to ensure I submit the sprint 1 separately

9420899

day-lee added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 5, 2025

day-lee self-requested a review April 5, 2025 19:36

day-lee reviewed Apr 5, 2025

View reviewed changes

Elfredah closed this by deleting the head repository May 19, 2025

		module.exports = calculateMedian;


		//======> solution to the right codes to solve the issue is below

Uh oh!

JAN 2025 ITP/ ELFREDAH KEVIN-ALERECHI/ DATA GROUPS/Sprint 2 #458

JAN 2025 ITP/ ELFREDAH KEVIN-ALERECHI/ DATA GROUPS/Sprint 2 #458

Uh oh!

Conversation

Elfredah commented Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

day-lee commented Apr 5, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

day-lee Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

day-lee commented Apr 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Elfredah commented Mar 30, 2025 •

edited

Loading

day-lee Apr 5, 2025 •

edited

Loading