PAWEL BROILO I MODULE - DATA -GROUPS I SPRINT 1 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @PawelBroilo Please make sure to add |
day-lee
added
Needs Review
day-lee
reviewed
Apr 7, 2025
There was a problem hiding this comment.
The file name doesn't match with the content. Test file should only contain the test suite. Is there a reason why you created a new Sprint 1 folder and files? It would be easier for you to code in the existing files in Sprint-1 folder.
Please write appropriate test cases.
day-lee
reviewed
Apr 7, 2025
| @@ -0,0 +1,4 @@ | |||
| function sum(elements) { | |||
There was a problem hiding this comment.
Please complete sum function according to the instruction written in sum.test.js file
day-lee
reviewed
Apr 7, 2025
| @@ -0,0 +1 @@ | |||
| function dedupe() {} | |||
There was a problem hiding this comment.
Please complete dedupe function according to the instruction written in dedupe.test.js file
day-lee
reviewed
Apr 7, 2025
| @@ -0,0 +1,12 @@ | |||
| // Refactor the implementation of includes to use a for...of loop | |||
|
|
|||
| function includes(list, target) { | |||
day-lee
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.