Skip to content

London | Nadarajah_Sripathmanathan | Reading-list | Week 3 #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

London | Nadarajah_Sripathmanathan | Reading-list | Week 3 #469

wants to merge 1 commit into from

Conversation

sripathman
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

@sripathman sripathman changed the title London | Nadarajah_Sripathmanathan | Reading-list , Could you review please London | Nadarajah_Sripathmanathan | Reading-list | Week 3 Mar 30, 2025
@sripathman
Copy link
Author

Dear Admin, I have done Reading-list , Could you review please

@sripathman sripathman added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 5, 2025
cjyuan
cjyuan reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code works great.

Can you update index.html accordingly and remove index1.html. After that, feel free to mark this as "Complete.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review with trainee action still to take.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sripathman @cjyuan @pathman