front end draft for Daniel to use #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set up other components and fix tweets to blooms bash the cors in this is obviously not right we're doing web components as per ticket i've put some events in as it's "seeable" for them this obviously needs simplifying a bunch now and tests and a layout refactoring cleaning up my mess and regularising, making it more comprehensible to trainees mid way refactor, going out maybe will write a layout now clean up a bit still tbh undecided if it makes sense to do this event driven approach minor tweak just renames mainly, found it a bit obscure reorganise into component folders and start checking through requirements and tests checkpoint forgot the utilities in this component go over tests just playwright tests - we don't want to get sidetracked by mock dom pain ok, opening this as a PR for tear apart check the tests all run
I didn't write all those tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we're doing web components as per ticket
bash the cors in and let Daniel sort out what he wants
i've put some events in as it's "seeable" for them
and tests and a layout
refactoring
cleaning up my mess and regularising, making it more comprehensible to trainees
still tbh undecided if it makes sense to do this event driven approach
reorganise into component folders
and start checking through requirements and tests
just playwright tests - we don't want to get sidetracked by mock dom pain
check the tests all run
I haven't put profile switching in yet - I might do that today.