ITP -Northwest- JAN 2025 | Jan Lo | Module-Structuring-and-Testing-Data Sprint 3 | WEEK 5 #377

JanLlw · 2025-03-11T22:33:31Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

alastair87 · 2025-03-16T14:52:01Z

@JanLlw Please include an explanation of your PR as asked for in the template.

I have confirmed that your code passes all the acceptance tests and if you refer to your code on GitHub you will find in-line comments with specific feedback.

One thing I recommend you do in future is split up your commits rather than committing all your changes in one. This makes it much easier to trace changes and the logic behind them (also selectively revert them) when you start working on more complex projects.

Sprint-3/1-key-implement/1-get-angle-type.js

Sprint-3/1-key-implement/2-is-proper-fraction.js

Sprint-3/1-key-implement/3-get-card-value.js

Sprint-3/3-mandatory-practice/implement/count.js

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

Sprint-3/3-mandatory-practice/implement/repeat.js

fix 9 task in sprint 3

ad2a052

JanLlw added the Needs Review Participant to add when requesting review label Mar 11, 2025

alastair87 self-assigned this Mar 16, 2025

alastair87 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Mar 16, 2025