LONDON_JAN25 | GIOSEF FERRARO | STRUCTURING_AND_TESTING_DATA | SPRINT 3

[Giosef92]

Self checklist

• [X ] I have committed my files one by one, on purpose, and for a reason
• [X ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• [X ] I have tested my changes
• [X ] My changes follow the style guide
• [X ] My changes meet the requirements of this task

[fearcyf]

Code looks fine

[fearcyf]

Code looks fine

[fearcyf]

Code is fine

[fearcyf]

Code is fine

[fearcyf]

Have a look at this link - > https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number

[fearcyf]

do about three expect statements for each condition to strengthen your tests

[fearcyf]

Could you explain your reasoning in a bit more detail - in particular your parseInt approach

[fearcyf]

This relates to line 10 - the if statement How do we ensure that rank returns single digits so that something like 2.2 doesn't slip through. See the link above

[fearcyf]

Could a for loop be written for tests to return number cards, have a look at this link -> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Loops_and_iteration

[fearcyf]

how could your Function be improved so that -> 111, 912, 413 returns "111th", "912th", "413th" respectively.

[fearcyf]

Good work overall - areas to be addressed has been commented on.