-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ITP_JAN_25 | HASAN DEMIROZ | Module-Structuring-and-Testing-Data | Sprint 3 #424
base: main
Are you sure you want to change the base?
Changes from 10 commits
a90809d
3c4e92c
c032ed8
2cf68cf
9050f92
82ababd
5dc2d85
5a11446
305933d
8f090c4
7383271
cb78dee
140079c
5cf3e22
73d6d0a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,11 @@ | |
// write one test at a time, and make it pass, build your solution up methodically | ||
|
||
function isProperFraction(numerator, denominator) { | ||
if (numerator < denominator) return true; | ||
if (Math.abs(numerator) < Math.abs(denominator)) | ||
return true; | ||
else if (Math.abs(numerator) > Math.abs(denominator)) return false; | ||
else if(Math.abs(numerator) === Math.abs(denominator)) return false; | ||
|
||
} | ||
|
||
// here's our helper again | ||
|
@@ -40,14 +44,23 @@ assertEquals(improperFraction, false); | |
// target output: true | ||
// Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true. | ||
const negativeFraction = isProperFraction(-4, 7); | ||
assertEquals(negativeFraction, true); | ||
// ====> complete with your assertion | ||
|
||
// Equal Numerator and Denominator check: | ||
// Input: numerator = 3, denominator = 3 | ||
// target output: false | ||
// Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false. | ||
const equalFraction = isProperFraction(3, 3); | ||
assertEquals(equalFraction, false); | ||
// ====> complete with your assertion | ||
|
||
// Stretch: | ||
// What other scenarios could you test for? | ||
const numeratorZero = isProperFraction(0, 3); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this return true, 0/3 is fraction or not? But it's nice you come up with this corner case. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The function updated and it returns false for the 0/3 is fraction or not case. |
||
assertEquals( numeratorZero, true); | ||
|
||
const denominatorZero = isProperFraction(5, 0); | ||
assertEquals(denominatorZero, false); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,12 @@ | |
// write one test at a time, and make it pass, build your solution up methodically | ||
// just make one change at a time -- don't rush -- programmers are deep and careful thinkers | ||
function getCardValue(card) { | ||
let rank = card.slice(0, -1); | ||
if (rank === "A") return 11; | ||
if (["J", "Q", "K", "10"].includes(rank)) return 10; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what happend if the input is something like "a♠" , 'j♠", should it still be accounted as the right input or not? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code has updated. Before the statement it makes it uppercase the it. |
||
let number = parseInt(rank); | ||
if (number >= 2 && number <= 9) return number; | ||
throw new Error("Invalid card rank."); | ||
} | ||
|
||
// You need to write assertions for your function to check it works in different cases | ||
|
@@ -25,27 +30,46 @@ function assertEquals(actualOutput, targetOutput) { | |
// Given a card string in the format "A♠" (representing a card in blackjack - the last character will always be an emoji for a suit, and all characters before will be a number 2-10, or one letter of J, Q, K, A), | ||
// When the function getCardValue is called with this card string as input, | ||
// Then it should return the numerical card value | ||
const aceofSpades = getCardValue("A♠"); | ||
assertEquals(aceofSpades, 11); | ||
const aceOfSpades = getCardValue("A♠"); | ||
assertEquals(aceOfSpades, 11); | ||
|
||
// Handle Number Cards (2-10): | ||
// Given a card with a rank between "2" and "9", | ||
// When the function is called with such a card, | ||
// Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5). | ||
const fiveofHearts = getCardValue("5♥"); | ||
const fiveOfHearts = getCardValue("5♥"); | ||
assertEquals( fiveOfHearts, 5); | ||
// ====> write your test here, and then add a line to pass the test in the function above | ||
|
||
// Handle Face Cards (J, Q, K): | ||
// Given a card with a rank of "10," "J," "Q," or "K", | ||
// When the function is called with such a card, | ||
// Then it should return the value 10, as these cards are worth 10 points each in blackjack. | ||
const kingOfDiamonds = getCardValue("K♦"); | ||
assertEquals(kingOfDiamonds, 10); | ||
|
||
|
||
// Handle Ace (A): | ||
// Given a card with a rank of "A", | ||
// When the function is called with an Ace, | ||
// Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack. | ||
const tenOfClubs = getCardValue("10♣"); | ||
assertEquals(tenOfClubs, 10); | ||
|
||
// Handle Invalid Cards: | ||
// Given a card with an invalid rank (neither a number nor a recognized face card), | ||
// When the function is called with such a card, | ||
// Then it should throw an error indicating "Invalid card rank." | ||
|
||
// Invalid card should throw an error | ||
try { | ||
getCardValue("1♣"); // 1 is not a valid rank in a standard deck | ||
} catch (error) { | ||
assertEquals(error.message, "Invalid card rank."); | ||
} | ||
|
||
try { | ||
getCardValue("Z♦"); // Z is not a valid card | ||
} catch (error) { | ||
assertEquals(error.message, "Invalid card rank."); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,9 @@ | ||
function isProperFraction(numerator, denominator) { | ||
if (numerator < denominator) return true; | ||
// add your completed function from key-implement here | ||
else if (numerator > denominator) return false; | ||
else if(numerator === denominator) return false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is that the function you already included in the previous file? where you have the math.abs(). also considering the situation of numerator and denominator could be zero. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code has updated and combined the else if cases. |
||
|
||
} | ||
|
||
module.exports = isProperFraction; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,21 @@ | ||
const isProperFraction = require("./2-is-proper-fraction"); | ||
|
||
test("should return true for a proper fraction", () => { | ||
expect(isProperFraction(2, 3)).toEqual(true); | ||
test("should return true for a proper fraction (2/3)",() => { | ||
expect(isProperFraction(2,3)).toBe(true); | ||
}); | ||
|
||
// Case 2: Identify Improper Fractions: | ||
test("should return true for a improper fraction (3/1)",() => { | ||
expect(isProperFraction(3,1)).toBe(false); | ||
}); | ||
|
||
// Case 3: Identify Negative Fractions: | ||
test("should return true for a negative fraction (-3/5)",() => { | ||
expect(isProperFraction(-3,5)).toBe(true); | ||
}); | ||
|
||
// Case 4: Identify Equal Numerator and Denominator: | ||
test("should return true for a equal numerator and denominator fraction (5/5)",() => { | ||
expect(isProperFraction(5,5)).toBe(false); | ||
}); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
function getCardValue(card) { | ||
// replace with your code from key-implement | ||
return 11; | ||
let rank = card.slice(0, -1); | ||
if (rank === "A") return 11; | ||
if (["J", "Q", "K", "10"].includes(rank)) return 10; | ||
if(!isNaN(rank)) return parseInt(rank); | ||
throw new Error("Invalid card rank."); | ||
} | ||
module.exports = getCardValue; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,29 @@ | ||
const getCardValue = require("./3-get-card-value"); | ||
|
||
test("should return 11 for Ace of Spades", () => { | ||
const aceofSpades = getCardValue("A♠"); | ||
expect(aceofSpades).toEqual(11); | ||
const aceOfSpades = getCardValue("A♠"); | ||
expect(aceOfSpades).toEqual(11); | ||
}); | ||
|
||
// Case 2: Handle Number Cards (2-10): | ||
test("should return 7 for seven of Spades", () => { | ||
const aceOfSpades = getCardValue("7♠"); | ||
expect(aceOfSpades).toEqual(7); | ||
}); | ||
|
||
// Case 3: Handle Face Cards (J, Q, K): | ||
test("should return 10 for King of Diamonds", () => { | ||
const aceOfSpades = getCardValue("K♦"); | ||
expect(aceOfSpades).toEqual(10); | ||
}); | ||
|
||
// Case 4: Handle Ace (A): | ||
// Case 5: Handle Invalid Cards: | ||
test("should return 10 for Ten or Clubs",() =>{ | ||
const aceOfSpades = getCardValue("5♠"); | ||
expect(aceOfSpades).toEqual(5); | ||
}); | ||
|
||
// Case 5: Handle Invalid Cards: | ||
test("should throw an error for an invalid card (Z♦)", () => { | ||
expect(() => getCardValue("Z♦")).toThrow("Invalid card rank."); | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
function countChar(stringOfCharacters, findCharacter) { | ||
return 5 | ||
return stringOfCharacters.split(findCharacter).length -1; | ||
} | ||
|
||
module.exports = countChar; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ const countChar = require("./count"); | |
test("should count multiple occurrences of a character", () => { | ||
const str = "aaaaa"; | ||
const char = "a"; | ||
const count = countChar(str, char); | ||
let count = countChar(str, char); | ||
expect(count).toEqual(5); | ||
}); | ||
|
||
|
@@ -22,3 +22,25 @@ test("should count multiple occurrences of a character", () => { | |
// And a character char that does not exist within the case-sensitive str, | ||
// When the function is called with these inputs, | ||
// Then it should return 0, indicating that no occurrences of the char were found in the case-sensitive str. | ||
|
||
test("should count multiple occurrences of l character", () => { | ||
const str = "hello"; | ||
const char = "l"; | ||
let count = countChar(str, char); | ||
expect(count).toEqual(2); | ||
}); | ||
|
||
test("should return 0 if because of case-sensitivity",() =>{ | ||
const str = "Car"; | ||
const char = "c"; | ||
const count = countChar(str,char); | ||
expect(count).toEqual(0); | ||
}); | ||
|
||
|
||
test("should return 0 if character does not appears",() =>{ | ||
const str = "apple"; | ||
const char = "c"; | ||
const count = countChar(str,char); | ||
expect(count).toEqual(0); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there is a corner case which could potentially failed . when findchar is empty string "". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is updated and fixed. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,10 @@ | ||
function getOrdinalNumber(num) { | ||
return "1st"; | ||
if (num === 1) return "1st"; | ||
else if (num === 2) return "2nd"; | ||
else if (num === 3) return "3rd"; | ||
else return num + "th"; | ||
|
||
|
||
} | ||
|
||
module.exports = getOrdinalNumber; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,3 +11,18 @@ const getOrdinalNumber = require("./get-ordinal-number"); | |
test("should return '1st' for 1", () => { | ||
expect(getOrdinalNumber(1)).toEqual("1st"); | ||
}); | ||
|
||
test("should return '2nd' for 2", () => { | ||
expect(getOrdinalNumber(2)).toEqual("2nd"); | ||
}); | ||
|
||
|
||
test("should return '8th' for 8", () => { | ||
expect(getOrdinalNumber(8)).toEqual("8th"); | ||
}); | ||
|
||
test("should return 'th' for greater than 3", () => { | ||
for (let number = 4; number < 20; number++) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 11th has been handled, but how about 21st, 31st? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The code has updated according to edge cases and works fine now. |
||
expect(getOrdinalNumber(number)).toEqual(number + "th"); | ||
} | ||
}); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,17 @@ | ||
function repeat() { | ||
return "hellohellohello"; | ||
function repeat(str, count) { | ||
if (count < 0) { | ||
throw new Error("Count must be a non-negative integer."); | ||
} | ||
|
||
if (count === 0) { | ||
return ""; | ||
} | ||
|
||
let result = ""; | ||
for (let i = 0; i < count; i++) { | ||
result += str; | ||
} | ||
return result; | ||
} | ||
|
||
module.exports = repeat; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you use >==, that would include situation 2,3 into one, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the code and used less line of codes. Thanks.