ITP_GLASGOW_MAR | HANNA_MYKYTIUK | MODULE_STRUCTURING_AND_TESTING_DATA | SPRINT_2 #441

HannaOdud · 2025-03-31T21:08:37Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
[x ] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[x ] I have tested my changes
[x ] My changes follow the style guide
[x ] My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

cjyuan · 2025-04-02T00:31:17Z

It seems the current branch is created from your Sprint-3 branch instead of from main.

Can you backup your files in this branch first and try the following steps to rebase it onto main?

This instructions assume you had created a branch named B2 from a branch named B1 instead of from main, and you wanted to rebase B2 from B1 to main. (In your case, B2 refers to the current branch, and B1 refers to your Sprint-3 branch,
coursework/sprint-3)

1. Open a terminal in VSCode

2. Switch to the branch you want to rebase (`B2`)

git switch B2

Note: You can check which branch is the current branch via the command git branch (to list all branches with current branch highlighted)

3. Rebase `B2` from `B1` onto `main`

git rebase --onto main B1 B2

For more details about this command, see
https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase#:~:text=interactive%20rebase%20display-,Advanced%20rebase%20application,-The%20command%20line

4. Update (and Overwrite) your files in branch B2 at Github

While you are in branch B2 and you have verified that it has been successfully rebased, execute the following command:
git push --force origin

cjyuan

Code is good.

I left you some suggestions to help you improve some of the code.

Please try to rebase the current branch onto main.

cjyuan · 2025-04-02T23:18:51Z

Sprint-2/1-key-errors/1.js

@@ -18,3 +18,13 @@ console.log(decimalNumber);

 // Finally, correct the code to fix the problem
 // =============> write your new code here
+
+function convertToPercentage(decimalNumber) {
+  decimalNumber = 0.5;


If we replace the parameter value, how do we expect to convert different numbers using this function?

cjyuan · 2025-04-02T23:27:41Z

Sprint-2/1-key-errors/1.js

+  decimalNumber = 0.5;
+  const percentage = `${decimalNumber * 100}%`;
+
+  console.log(decimalNumber);


I think the function is expected to compute and return a percentage string when given a number; it should not output 0.5 every time the function is called.

If we want to output 0.25 as 25%, we could write console.log( convertToPercentage(0.25) ); outside the function.

cjyuan · 2025-04-02T23:29:20Z

Sprint-2/3-mandatory-implement/1-bmi.js

 function calculateBMI(weight, height) {
+    let BMI = weight/(height*height);
+    return BMI.toFixed(1);
+


What type of value do you think the function should return? A number or a string?
Does your function return the type of value you think it should return?

cjyuan · 2025-04-02T23:32:21Z

Sprint-2/4-mandatory-interpret/time-format.js


 // Call formatTimeDisplay with an input of 61, now answer the following:

 // b) What is the value assigned to num when pad is called for the first time?
-// =============> write your answer here
+// =============> write your answer here: 00:01:01


I think you misread the question. That's not the value assigned to num when the function pad() is called for the first time.

cjyuan · 2025-04-02T23:38:08Z

Sprint-2/5-stretch-extend/format-time.js

+const currentOutput6 = formatAs12HourClock("12:00");
+const targetOutput6 = "00:00 pm";
+console.assert(
+  currentOutput5 === targetOutput5,
+  `current output: ${currentOutput5}, target output: ${targetOutput5}`
+);


I think "12:00" should be converted to "12:00 pm" (noon).

cjyuan · 2025-04-02T23:39:43Z

Sprint-2/5-stretch-extend/format-time.js

+);
+
+// hours = 00 and minutes = 00
+const currentOutput5 = formatAs12HourClock("00:00");


I think "00:00" should be converted to "12:00 am" (midnight).

cjyuan

The code is improved! I think there are a few some improvements you can make. After you make the necessary changes, feel free to mark this as "Complete" (provided you also rebase the branch onto main).

cjyuan · 2025-04-03T16:14:39Z

Sprint-2/3-mandatory-implement/1-bmi.js

@@ -16,8 +16,9 @@

 function calculateBMI(weight, height) {
    let BMI = weight/(height*height);
-    return BMI.toFixed(1);
+    return Math.round(BMI * 100) / 100;


This approach works but it would round the number to two decimal place (because of 100)

cjyuan · 2025-04-03T16:16:18Z

Sprint-2/4-mandatory-interpret/time-format.js

@@ -23,7 +23,7 @@ console.log(formatTimeDisplay(61));
 // Call formatTimeDisplay with an input of 61, now answer the following:

 // b) What is the value assigned to num when pad is called for the first time?
-// =============> write your answer here: 00:01:01
+// =============> write your answer here: 61


num here refer to the parameter of pad(). When pad() is called the first time, the parameter passed to the function is not 61.

cjyuan · 2025-04-03T16:17:45Z

Sprint-2/5-stretch-extend/format-time.js

 console.assert(
  currentOutput5 === targetOutput5,
  `current output: ${currentOutput5}, target output: ${targetOutput5}`
 );

 // hours = 12 and minutes = 00
 const currentOutput6 = formatAs12HourClock("12:00");
-const targetOutput6 = "00:00 pm";
+const targetOutput6 = "12:00 pm";


Does your function return this expected value?

cjyuan

Changes look good.

After you rebase this branch (so that there is no modified files in Sprint-3 folder), feel free to mark this as "Complete".

HannaOdud added 5 commits March 5, 2025 19:19

key implementation exercises

f4e9c6b

mandatory rewrite exercises

6c4cfde

mandatory practice exercises

980fac0

stretch-investigate exercises

3ee1a41

Sprint 2

eba5d0c

HannaOdud added the Needs Review Participant to add when requesting review label Apr 1, 2025

cjyuan added the 👀 Review Git Changes requested to do with Git label Apr 2, 2025

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels Apr 2, 2025

cjyuan reviewed Apr 2, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 2, 2025

fixes to sprint 2

5de2a8e

HannaOdud requested a review from cjyuan April 3, 2025 15:18

cjyuan reviewed Apr 3, 2025

View reviewed changes

fix2 for sprint2

06bd8cf

HannaOdud requested a review from cjyuan April 3, 2025 19:55

cjyuan reviewed Apr 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ITP_GLASGOW_MAR | HANNA_MYKYTIUK | MODULE_STRUCTURING_AND_TESTING_DATA | SPRINT_2 #441

ITP_GLASGOW_MAR | HANNA_MYKYTIUK | MODULE_STRUCTURING_AND_TESTING_DATA | SPRINT_2 #441

HannaOdud commented Mar 31, 2025

cjyuan commented Apr 2, 2025

cjyuan left a comment •

edited

Loading

cjyuan Apr 2, 2025

cjyuan Apr 2, 2025

cjyuan Apr 2, 2025

cjyuan Apr 2, 2025

cjyuan Apr 2, 2025

cjyuan Apr 2, 2025

cjyuan left a comment •

edited

Loading

cjyuan Apr 3, 2025

cjyuan Apr 3, 2025

cjyuan Apr 3, 2025

cjyuan left a comment

ITP_GLASGOW_MAR | HANNA_MYKYTIUK | MODULE_STRUCTURING_AND_TESTING_DATA | SPRINT_2 #441

Are you sure you want to change the base?

ITP_GLASGOW_MAR | HANNA_MYKYTIUK | MODULE_STRUCTURING_AND_TESTING_DATA | SPRINT_2 #441

Conversation

HannaOdud commented Mar 31, 2025

Learners, PR Template

Changelist

Questions

cjyuan commented Apr 2, 2025

1. Open a terminal in VSCode

2. Switch to the branch you want to rebase (B2)

3. Rebase B2 from B1 onto main

4. Update (and Overwrite) your files in branch B2 at Github

cjyuan left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjyuan left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cjyuan left a comment

Choose a reason for hiding this comment

2. Switch to the branch you want to rebase (`B2`)

3. Rebase `B2` from `B1` onto `main`

cjyuan left a comment •

edited

Loading

cjyuan left a comment •

edited

Loading