Skip to content

London | 25-SDC-July | Andrei Filippov | Sprint 2 | jq exercises #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Droid-An wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Andrei Filippov | Sprint 2 | jq exercises #106

Droid-An wants to merge 4 commits into from

Conversation

@Droid-An
Copy link

@Droid-An Droid-An commented Jul 20, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

done exercises

Questions

no questions

@Droid-An Droid-An added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module and removed 📅 Sprint 1 Assigned during Sprint 1 of this module labels Jul 20, 2025
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 1, 2025
LonMcGregor
LonMcGregor reviewed Aug 1, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on this sprint. Your solutions work, but there may be ways they could be simplified

jq/script-11.sh Outdated
# The input for this script is the scores.json file.
# TODO: Write a command to output the total of adding together all scores from all games from all players.
# Your output should be exactly the number 164.
jq '[.[].scores] | add | add' scores.json No newline at end of file
Copy link

@LonMcGregor LonMcGregor Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could probably simplify this command to only need a single add. Can you figure out how to do this?

Copy link
Author

@Droid-An Droid-An Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, the only solution that comes to my mind is to use flatten method

jq/script-05.sh Outdated
# The input for this script is the scores.json file.
# TODO: Write a command to output the names of each player, as well as their city.
# Your output should contain 6 lines, each with two words on it.
jq -r '.[]| {"name":.name, "city":.city} | join(" ")' scores.json No newline at end of file
Copy link

@LonMcGregor LonMcGregor Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution of constructing a new json object and joining it works, but you could probably simplify it a bit. Do you know how to directly build a string in a jq command?

Copy link
Author

@Droid-An Droid-An Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, cool. I didn't know that I can concatenate strings in jq, but now I know that I need to use + operator to do it.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 1, 2025
@Droid-An Droid-An added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 1, 2025
@LonMcGregor
Copy link

LonMcGregor commented Aug 4, 2025

Yes, string concatenation makes things a bit simpler. Good work using that.

As for your solution using [.[].scores] | flatten | add - right now you have two pipes in your command. There should be a way to complete it with a single pipe.

Remember what the add function does and what it operates on - a flat array. And remember how you are building your query - making a new array out of some result. Do you know of any way you can get the entire scores array in the first part of your query already as a flat sequence of values you could then construct a flat array out of (without needing to use the flatten function)?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 4, 2025
@Droid-An Droid-An added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 20, 2025
@LonMcGregor
Copy link

LonMcGregor commented Aug 25, 2025

Great work solving this - you are done with this sprint task now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Droid-An @LonMcGregor