West Midlands | SDC-July | Gabriel Deng | Sprint 4 | Implement shell tools in python

[gai93003]

Having people write s/s/S/ is a little more confusing than s/i/I/
for their first exercise.

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[LonMcGregor]

Hi, I can't review your code yet. If you look at the "files changed" tab on this PR you will see the problem as there are hundreds of files that don't need to be there.

It looks like you're using a virtual environment, which is a good idea if you are using multiple libraries, but needs to be handled carefully within a VCS. Could you look up how to properly handle python virtual environments within git so this problem doesn't happen?

[LonMcGregor]

That's better - only the files relevant are committed. In future be careful of committing the compiled python binaries, they don't need to be there.

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[gai93003]

That's better - only the files relevant are committed. In future be careful of committing the compiled python binaries, they don't need to be there.

Thanks, I was not yet familiar with the running python. I will look out for these things in the future