Glasgow | 25-SDC-July | Prati Amalden | Sprint 4 | Implement shell tools in python#152
Open
PratiAmalden wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
Conversation
PratiAmalden
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 19, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Hi, Great work on these implementations so far. I can see a few areas where you could improve further. I've left comments as pointers
| # Gets all file names (including hidden ones) | ||
| files = os.listdir(args.dir) | ||
| except (FileNotFoundError, NotADirectoryError) as err: | ||
| print(f"ls: can't access: '{args.dir}': {err}") |
There was a problem hiding this comment.
It is good that you are handling errors. Here you are handling a NotADirectoryError. What happens if you try to use the original ls application with a regular file?
There was a problem hiding this comment.
I have a few questions to ask about this file:
- Why are you making extra variables for lines, words, etc which are the same as the values in the args dictionary?
- Can you see what happens in your program if you try to combine multiple arguments in one command?
- Can you see where there is duplication that could be reduced?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.