London | 25-SDC-July | Eyuel Abraham | Sprint 4 | Implement shell tool python

[eyuell21]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[LonMcGregor]

Good work on these tasks so far, I've left some pointers to get you started on improvements

[LonMcGregor]

It looks like the formatting of the output might not be working quite right. Can you find out why and fix it?

(Hint: Try running with a wildcard for all the files in the sample directory)

[LonMcGregor]

This is a very good implementation, but I think you might have misread -1 in the readme as -l. You can keep -l, which is a good stretch task, but can you add the implementation for -1 as well?

[LonMcGregor]

This implementation works well but you might be able to improve your code:

• Is there a reason you create variables that store data that is already stored in the args dictionary?
• Can you see where there is duplication in your code. Can you fix that?

[eyuell21]

Creating show_line, show_word, and show_char isn’t necessary, since you can reference args.line, args.word, and args.character directly. The show_all value can also be derived from these flags on the fly. Thank you for flagging it.