London | 25-SDC-July | Mikiyas Gebremichael | Sprint 4 | Implement Shell Tool Python #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mikiyas-STP
added
📅 Sprint 4
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 19, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Remember to update the default PR text when submitting on github.
Good start on this sprint's tasks, I have spotted a few areas in 1 file where you could improve code further
There was a problem hiding this comment.
Your implementation works well, but your code could be improved a bit. Can you see any issues with the code style you could fix?
Author
There was a problem hiding this comment.
@LonMcGregor thank you for your feedback on this PR. I have tried to separate the logic using one more additional method and make the main method clean and organised. Can you please review back this PR and approve it so that i could close it if it is sufficient. Thankyou
LonMcGregor
added
Reviewed
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains my work on implementing the shell tool using python.
Questions
No questions for this PR