Manchester | 25-SDC-Nov | Geraldine Edwards | Sprint 1 | Individual-Shell-Tools #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geraldine-Edwards
added
the
Needs Review
LonMcGregor
reviewed
Nov 19, 2025
| # If a line starts with a number and a space, make the line instead end with a space and the number. | ||
| # So line 6 which currently reads "37 Alisha" should instead read "Alisha 37". | ||
| # The output should contain 11 lines. | ||
| sed -E '/^[0-9]+ / s/^([0-9]+) (.*)/\2 \1/' input.txt No newline at end of file |
There was a problem hiding this comment.
Is this first ^[0-9]+ necessary here? What is it doing?
Author
There was a problem hiding this comment.
Oh yes I see, I'm not sure why it is there, I think I forgot to delete it when I was first building the command...and then when I ran bash it didn't cause an error so I have not noticed that it was still there...I have removed it now.
There was a problem hiding this comment.
You've comitted this by accident, can you revert it from this PR?
|
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further |
LonMcGregor
added
Reviewed
Geraldine-Edwards
added
Needs Review
…s in 'cat' exercises
…iles in 'wc' exercises
Geraldine-Edwards
force-pushed
the
individual-shell-tools
branch
from
630ba69 to
e2ebd7f
Compare
|
This looks good now, well done |
LonMcGregor
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR contains the answers to the shell script exercises in the awk, cat, grep, ls, sed, and wc directories of the individual-shell-tools directory
Questions
N/A