Skip to content

Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Number-Systems #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RahwaZeslusHaile wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Number-Systems #192

RahwaZeslusHaile wants to merge 2 commits into from

Conversation

@RahwaZeslusHaile
Copy link

@RahwaZeslusHaile RahwaZeslusHaile commented Nov 8, 2025 •
edited
Loading

Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Number-Systems

Learners, PR Template

Self checklist

  • [ X] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ X] My changes meet the requirements of the task
  • [ X] I have tested my changes
  • [ X] My changes follow the style guide

Changelist

  • Added answers to number systems exercises in README.md, including:
    • Conversion between decimal, binary, and hexadecimal
    • Understanding of ASCII and grayscale/RGB interpretations of bytes

Question

Could you please review my answers and let me know if there’s anything I should improve?
Thank you in advance!

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@RahwaZeslusHaile RahwaZeslusHaile changed the title Add answers to exercise 1 01 Number systems exercises Nov 9, 2025
@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@RahwaZeslusHaile RahwaZeslusHaile changed the title 01 Number systems exercises Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Number-Systems Nov 9, 2025
@RahwaZeslusHaile RahwaZeslusHaile added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 9, 2025
LonMcGregor
LonMcGregor reviewed Nov 17, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

number-systems/README.md Outdated
Answer:1110

Convert the binary number 101101 to decimal:
Answer:
Copy link

@LonMcGregor LonMcGregor Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To turn into decimal, think about how to multiply each position according to a power of two

number-systems/README.md Outdated
Answer:11111

What is 10001 + 10001?
Answer:
Copy link

@LonMcGregor LonMcGregor Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're struggling, Try adding these the same way you may have learned with addition: start at the right, and add in columns

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 17, 2025
@RahwaZeslusHaile
Copy link
Author

RahwaZeslusHaile commented Nov 27, 2025

@LonMcGregor Thank you so much for your review! I was a bit surprised to see this because I remember finishing all the exercises, but it looks like my pull request got a bit messy. I really appreciate you pointing this out and helping me clean up my GitHub — it was very helpful.

@LonMcGregor
Copy link

LonMcGregor commented Dec 1, 2025

Great. This looks done now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RahwaZeslusHaile @LonMcGregor