Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Individual shell tools#198
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Individual shell tools#198RahwaZeslusHaile wants to merge 13 commits intoCodeYourFuture:mainfrom
Conversation
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
RahwaZeslusHaile
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
3 similar comments
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
To answer your question: I can't see any issues with efficiency here
|
|
||
| # TODO: Write a command which lists all of the files in the directory named child-directory. | ||
| # The output should be a list of names: helper-1.txt, helper-2.txt, helper-3.txt. | ||
| ls "child-directory" No newline at end of file |
There was a problem hiding this comment.
I add quotes for safety, because if the folder name ever contains spaces or special characters, the shell will interpret it incorrectly. Without quotes, a name with spaces would be treated as separate arguments and cause errors.
| # If a line starts with a number and a space, make the line instead end with a space and the number. | ||
| # So line 6 which currently reads "37 Alisha" should instead read "Alisha 37". | ||
| # The output should contain 11 lines. | ||
| sed -E "s/^[[:space:]]*([0-9]+)[[:space:]]+(.*)$/\2 \1/" input.txt No newline at end of file |
There was a problem hiding this comment.
Do you need to specify [[:space:]] in this manner to match on spaces?
There was a problem hiding this comment.
I added [[:space:]] in the sed command for safety because it matches any whitespace character (spaces or tabs). For my input, which only contains spaces, it wasn’t strictly necessary, but using [[:space:]] makes the command more robust and portable for files that might contain tabs or mixed whitespace.
There was a problem hiding this comment.
Thanks for clarifying, it's good you know these different methods that can help depending on the input
LonMcGregor
added
Reviewed
RahwaZeslusHaile
force-pushed
the
individual-shell-tools
branch
from
2ac7f9a to
a9cb0f8
Compare
|
@LonMcGregor Thanks for the feedback! I’ve updated the sed command to swap numbers and names correctly and simplified it for the current input. |
|
This looks complete now, well done |
LonMcGregor
added
Complete
2 participants
Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Individual Shell Tools
Learners, PR Template
Self checklist
Changelist
lsandls -Rto list files and directoriescatandwcto inspect file content and countsgrepto filter lines in filessedto edit text and transform linesawkto extract specific fields from structured dataQuestion
Could you please review my solutions and let me know if there is anything I can improve, especially in terms of Bash command efficiency or clarity?