Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Individual shell tools #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

RahwaZeslusHaile wants to merge 13 commits into CodeYourFuture:main from RahwaZeslusHaile:individual-shell-tools

RahwaZeslusHaile commented Nov 9, 2025 •

edited

Loading

Manchester | 25-SDC-Nov | Rahwa Haile | Sprint 1 | Individual Shell Tools

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed exercises using core shell tools:
- Used ls and ls -R to list files and directories
- Used cat and wc to inspect file content and counts
- Used grep to filter lines in files
- Used sed to edit text and transform lines
- Used awk to extract specific fields from structured data
All script files updated to include working commands.
Verified outputs match the expected results.

Question

Could you please review my solutions and let me know if there is anything I can improve, especially in terms of Bash command efficiency or clarity?

RahwaZeslusHaile added 6 commits

November 9, 2025 14:16


          awk exercises done

139ddaf


          cat exercises done

3060f99


          Complete grep exercise

d9dc541


          Completed shell tools ls tasks

9b6093b


          Completed sed shell tool tasks

2a03983


          Completed wc shell tool tasks

d0ec01b

github-actions bot commented Nov 9, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

RahwaZeslusHaile added the Needs Review label

github-actions bot commented Nov 9, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

3 similar comments

github-actions bot commented Nov 9, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Nov 9, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Nov 9, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

RahwaZeslusHaile and others added 4 commits

November 9, 2025 21:10


          Correcting the counting of word to print a number

cd830fc


          Fix Individual Shell Tools scripts so all exercises pass

c285238


          Update script-03.sh to pass the test

c8fcdae


          Modify wc command to include line, word, and char counts

a332f8c

github-actions bot commented Nov 11, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment

github-actions bot commented Nov 11, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

RahwaZeslusHaile added 2 commits

November 13, 2025 12:20


          some improvment to the sheel tools

e263848


          Merge branch 'individual-shell-tools' of https://github.com/RahwaZesl…

a9cb0f8

…usHaile/Module-Tools into individual-shell-tools

LonMcGregor reviewed

View reviewed changes

LonMcGregor left a comment

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

To answer your question: I can't see any issues with efficiency here

individual-shell-tools/ls/script-02.sh

               # TODO: Write a command which lists all of the files in the directory named child-directory.
               # The output should be a list of names: helper-1.txt, helper-2.txt, helper-3.txt.
+              ls "child-directory"

                
                    No newline at end of file

LonMcGregor Nov 19, 2025

Why do you use the "quotes" here?

Author

RahwaZeslusHaile Nov 27, 2025

I add quotes for safety, because if the folder name ever contains spaces or special characters, the shell will interpret it incorrectly. Without quotes, a name with spaces would be treated as separate arguments and cause errors.

LonMcGregor Dec 1, 2025

Good answer

individual-shell-tools/sed/script-05.sh Outdated

               # If a line starts with a number and a space, make the line instead end with a space and the number.
               # So line 6 which currently reads "37 Alisha" should instead read "Alisha 37".
               # The output should contain 11 lines.
+              sed -E "s/^[[:space:]]*([0-9]+)[[:space:]]+(.*)$/\2 \1/" input.txt

                
                    No newline at end of file

LonMcGregor Nov 19, 2025

Do you need to specify [[:space:]] in this manner to match on spaces?

Author

RahwaZeslusHaile Nov 27, 2025

I added [[:space:]] in the sed command for safety because it matches any whitespace character (spaces or tabs). For my input, which only contains spaces, it wasn’t strictly necessary, but using [[:space:]] makes the command more robust and portable for files that might contain tabs or mixed whitespace.

LonMcGregor Dec 1, 2025

Thanks for clarifying, it's good you know these different methods that can help depending on the input

LonMcGregor added Reviewed and removed Needs Review labels

RahwaZeslusHaile force-pushed the individual-shell-tools branch from 2ac7f9a to a9cb0f8 Compare

November 21, 2025 20:51


          Simplify sed command for swapping numbers and names

Author

RahwaZeslusHaile commented Nov 27, 2025

@LonMcGregor Thanks for the feedback! I’ve updated the sed command to swap numbers and names correctly and simplified it for the current input.

LonMcGregor commented Dec 1, 2025

This looks complete now, well done

LonMcGregor added Complete and removed Reviewed labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels