London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 1 | Individual -Shell -Tools #200
London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 1 | Individual -Shell -Tools #200zohrehKazemianpour wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
zohrehKazemianpour
added
the
Needs Review
zohrehKazemianpour
changed the title
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this sprint's tasks, I have spotted a few areas where you could improve code further
| # So line 6 which currently reads "37 Alisha" should instead read "Alisha 37". | ||
| # The output should contain 11 lines. | ||
| sed -E 's#^([0-9]*) (.*)#\2 \1#' input.txt | ||
| # I changed the delimiter to # to make it more readable for me. No newline at end of file |
There was a problem hiding this comment.
Good idea to comment to explain this approach, well done
There was a problem hiding this comment.
You've comitted this by accident, can you revert it from this PR?
There was a problem hiding this comment.
Thanks for catching that! This commit has been removed from this PR now
LonMcGregor
added
Reviewed
zohrehKazemianpour
force-pushed
the
shell-tools-practice
branch
from
d25443a to
c84d0d4
Compare
Hi @LonMcGregor, thank you for the feedback and apologies for the incorrect commit in this PR. I've removed it from the commit list. Please let me know if I need to change anything else. |
|
Great, this PR looks complete now |
LonMcGregor
added
Complete
Thanks for approving this PR! I just wanted to let you know that I found out the binary commit was accidentally in my main branch, which is why it appeared in all of my PRs. I've cleaned up main and rebased all the other open PRs to remove it. Then I noticed all of the commit times had changed to today's date. I think that's because of the rebase rewriting the history. |
|
Yes, sometimes how you merge can affect the codebase. This is a good reason to use branches, to avoid making unwanted changes to the main branch by accident! |
2 participants
Self checklist
Changelist
Completed all exercises for individual shell tools (ls, cat, wc, grep, sed, awk).