Skip to content

London |25-SDC-NOV| Fatma Degirmenci |Sprint 1 | Individual Shell Tools#206

Open
fatmaevin wants to merge 7 commits intoCodeYourFuture:mainfrom
fatmaevin:individual-shell-tools
Open

London |25-SDC-NOV| Fatma Degirmenci |Sprint 1 | Individual Shell Tools#206
fatmaevin wants to merge 7 commits intoCodeYourFuture:mainfrom
fatmaevin:individual-shell-tools

Conversation

@fatmaevin
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@fatmaevin fatmaevin added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels Nov 11, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

set -euo pipefail

# TODO: Write a command to output the contents of all of the files inside the helper-files directory to the terminal.
cat ../helper-files/helper-1.txt ../helper-files/helper-2.txt ../helper-files/helper-3.txt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way of doing the same without manually listing every file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ,I’ve updated the command as you suggested.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 19, 2025
@fatmaevin fatmaevin added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 19, 2025
@LonMcGregor
Copy link

great!

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants