London | 25-SDC-Nov | Jesus del Moral | Sprint 2 | Shell pipelines#228
London | 25-SDC-Nov | Jesus del Moral | Sprint 2 | Shell pipelines#228delmorallopez wants to merge 4 commits intoCodeYourFuture:mainfrom
Conversation
delmorallopez
changed the title
delmorallopez
added
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Did you mean to make changes to all these files? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the shell pipelines sprint task. I can't continue reviewing until the PR is made more specific.
LonMcGregor
added
Reviewed
|
Include the command ls, grep, tr, sort, uniq, head, tail My changes meet the requirements of the task Contains exercises to help you practice combining shell tools in pipelines. Each folder is named after a group of tools, and contains exercises to practice using them. |
delmorallopez
added
the
Needs Review
delmorallopez
force-pushed
the
shell-pipelines
branch
from
a346317 to
ae19e63
Compare
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
This looks good, just one issue in one of the tasks for you to take another look at
shell-pipelines/ls-grep/script-04.sh
Outdated
| # TODO: Write a command to count the number of files in the sample-files directory whose name starts with an upper case letter and doesn't contain any other upper case letters. | ||
| # Your output should be the number 7. | ||
|
|
||
| ls sample-files | grep '^[A-Z][^A-Z]*$' No newline at end of file |
There was a problem hiding this comment.
This task is asking to count the output, do you remember how to make grep do that?
There was a problem hiding this comment.
The script has been modified and working properly
LonMcGregor
added
Complete
|
Great! |
LonMcGregor
added
Complete
2 participants
Include the command ls, grep, tr, sort, uniq, head, tail
My changes meet the requirements of the task
I have tested my changes
Contains exercises to help you practice combining shell tools in pipelines.
Each folder is named after a group of tools, and contains exercises to practice using them.